Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: cmake,run-make-check.sh: disable SPDK by default #30183

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 5, 2019

NOTE: this PR disables the SPDK tests in "make check" because according to @liewegas 's review comment in #29728 the feature is not being used in production.

backport tracker: https://tracker.ceph.com/issues/41351


backport of #29728
parent tracker: https://tracker.ceph.com/issues/41330

this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@smithfarm smithfarm added this to the mimic milestone Sep 5, 2019
@smithfarm smithfarm added the core label Sep 5, 2019
@smithfarm smithfarm requested review from tchaikov, liewegas and neha-ojha Sep 5, 2019
@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Sep 5, 2019

please drop "cmake: make WITH_SPDK a dependent option" from this PR. we don't use cmake 3.10 in mimic.

but we still enable it in `run-make-check.sh`

* cmake: disable SPDK by default
* run-make-check.sh: enable WITH_SPDK so at least we can ensure it
  builds
* deb,rpm: add uuid-dev / libuuid-devel as a "make check" dependency

Fixes: https://tracker.ceph.com/issues/41330
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 3234fb3)

Conflicts:
        CMakeLists.txt
	ceph.spec.in
	debian/control
	run-make-check.sh
- disable SPDK for mimic, even in run-make-check.sh, since the feature is not
  being used in production
@smithfarm smithfarm force-pushed the smithfarm:wip-41351-mimic branch from a797af2 to 1681a48 Sep 5, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 5, 2019

@tchaikov Thanks; done.

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Sep 30, 2019

@yuriw yuriw merged commit 376428a into ceph:mimic Oct 3, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41351-mimic branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.