Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radosgw-admin: add --uid check in bucket list command #30194

Merged
merged 1 commit into from Sep 19, 2019

Conversation

vumrao
Copy link
Contributor

@vumrao vumrao commented Sep 5, 2019

radosgw-admin: add --uid check in bucket list command
Fixes: https://tracker.ceph.com/issues/41589

@vumrao
Copy link
Contributor Author

vumrao commented Sep 5, 2019

  • The vstart cluster results:
[root@3cfea3e7c7e2 build]# bin/radosgw-admin user list
[
    "56789abcdef0123456789abcdef0123456789abcdef0123456789abcdef01234",
    "testx$9876543210abcdef0123456789abcdef0123456789abcdef0123456789abcdef",
    "0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef",
    "test",
    "testid"
]
  • Not providing value to the argument --uid
[root@3cfea3e7c7e2 build]# bin/radosgw-admin bucket list --uid=
bad uid
  • Providing a user which does not exist
[root@3cfea3e7c7e2 build]# bin/radosgw-admin bucket list --uid=xyz
ERROR: could not find user: xyz
  • User with buckets
[root@3cfea3e7c7e2 build]# bin/radosgw-admin bucket list --uid=testid
[
    "my-new-bucket1",
    "my-new-bucket2",
    "my-new-bucket3",
    "my-new-bucket4",
    "my-new-bucket5"
]
  • User without buckets
[root@3cfea3e7c7e2 build]# bin/radosgw-admin bucket list --uid=test
[]

Copy link
Contributor

@mattbenjamin mattbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/rgw/rgw_admin.cc Show resolved Hide resolved
@vumrao
Copy link
Contributor Author

vumrao commented Sep 6, 2019

  • After Matt suggestion test result from vstart cluster:
# bin/radosgw-admin bucket list --uid=
no value for uid

@cbodley
Copy link
Contributor

cbodley commented Sep 19, 2019

@cbodley cbodley merged commit 2c82b29 into ceph:master Sep 19, 2019
@vumrao
Copy link
Contributor Author

vumrao commented Sep 19, 2019

Thank you @cbodley.

@vumrao vumrao deleted the wip-vumrao-41589 branch September 26, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants