Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesmimic: core: mon: C_AckMarkedDown has not handled the Callback Arguments #30213
Conversation
smithfarm
changed the title
src/mon/OSDMonitor.cc
Outdated
| } else if (r == -EAGAIN) { | ||
| osdmon->dispatch(op); | ||
| } else { | ||
| ceph_abort_msgf("C_AckMarkedDown: unknown result %d", r); |
This comment has been minimized.
This comment has been minimized.
tchaikov
Sep 6, 2019
Contributor
Suggested change
| ceph_abort_msgf("C_AckMarkedDown: unknown result %d", r); | |
| derr << "C_AckMarkedDown: unknown result " << r << dendl; | |
| ceph_abort(); |
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/OSDMonitor.cc:1071:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
if (pgs_to_check.size() < g_conf->mon_clean_pg_upmaps_per_chunk * 2) {
~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/OSDMonitor.cc: In member function 'virtual void C_AckMarkedDown::_finish(int)':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/OSDMonitor.cc:2291:9: error: 'ceph_abort_msgf' was not declared in this scope
ceph_abort_msgf("C_AckMarkedDown: unknown result %d", r);
^~~~~~~~~~~~~~~
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/OSDMonitor.cc:2291:9: note: suggested alternative: 'ceph_abort_msg'
ceph_abort_msgf("C_AckMarkedDown: unknown result %d", r);
^~~~~~~~~~~~~~~
ceph_abort_msg
make[3]: *** [src/mon/CMakeFiles/mon.dir/OSDMonitor.cc.o] Error 1
we don't have ceph_abort_msgf() back in mimic.
This comment has been minimized.
This comment has been minimized.
|
@tchaikov Thanks |
smithfarm
force-pushed the
smithfarm:wip-41449-mimic
branch
2 times, most recently
from
8f0f0bf
to
7f4eb5f
This comment has been minimized.
This comment has been minimized.
|
@tchaikov It doesn't like Any idea? |
src/mon/OSDMonitor.cc
Outdated
| } else if (r == -EAGAIN) { | ||
| osdmon->dispatch(op); | ||
| } else { | ||
| derr << "C_AckMarkedDown: unknown result" << r << dendl; |
This comment has been minimized.
This comment has been minimized.
tchaikov
Sep 10, 2019
Contributor
Suggested change
| derr << "C_AckMarkedDown: unknown result" << r << dendl; | |
| lgeneric_derr(osdmon->cct) << "C_AckMarkedDown: unknown result" << r << dendl; |
in C_AckMarkedDown,we add a process that handle _finish(int) Callback Arguments Fixes: https://tracker.ceph.com/issues/41217 Signed-off-by: NancySu05 <su_nan@inspur.com> (cherry picked from commit 57e8411) Conflicts: src/mon/OSDMonitor.cc - MOSDMarkMeDown ctor takes fewer arguments in mimic - no "ceph_abort_msgf" function in mimic
This comment has been minimized.
This comment has been minimized.
|
The |
This comment has been minimized.
This comment has been minimized.
|
jenkins test docs |
This comment has been minimized.
This comment has been minimized.
|
@tchaikov Please have another look? |
This comment has been minimized.
This comment has been minimized.
|
@smithfarm pls rebase --- pr 30213 --- pulling https://github.com/smithfarm/ceph.git branch wip-41449-mimic
|
yuriw
added
needs-rebase
and removed
luminous-batch-1
needs-qa
wip-yuri8-testing
labels
This comment has been minimized.
This comment has been minimized.
|
@yuriw Sorry - my mistake. I added |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
smithfarm commentedSep 6, 2019
backport tracker: https://tracker.ceph.com/issues/41449
backport of #29624
parent tracker: https://tracker.ceph.com/issues/41217
this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh