Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: osd: clear PG_STATE_CLEAN when repair object #30243

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Sep 7, 2019

there is a race be found, when we repair object on clean state,
we queue a DoRecovery peering event, but before the peering event
dequeue,a snaptrim event on the missing object's snap dequeue,
then we will get pass the context< SnapTrimmer >().can_trim()
and go to get the context of the missing object(snapdir)

we can avoid this by clear clean state when we found missing..

Fixes: https://tracker.ceph.com/issues/41348

Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>
(cherry picked from commit 521f095)

Conflicts:
	src/osd/PrimaryLogPG.cc
- assert() instead of ceph_assert(), and Feature PR
  #26942 ("Improvements to auto repair") is
  not being backported
@smithfarm smithfarm added this to the mimic milestone Sep 7, 2019
@smithfarm smithfarm added the core label Sep 7, 2019
@smithfarm smithfarm requested review from tchaikov and dzafman Sep 7, 2019
@smithfarm smithfarm changed the title mimic: osd: clear PG_STATE_CLEAN when repair object mimic: core: osd: clear PG_STATE_CLEAN when repair object Sep 7, 2019
@neha-ojha

This comment has been minimized.

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Sep 9, 2019

@neha-ojha: Ack, see #30271

@dzafman
dzafman approved these changes Sep 9, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Sep 30, 2019

@yuriw yuriw merged commit a4a2cf2 into ceph:mimic Oct 3, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41442-mimic branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.