Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: ceph-volume: fix stderr failure to decode/encode when redirected #30300

Merged
merged 7 commits into from Sep 11, 2019

Conversation

@alfredodeza
Copy link
Contributor

commented Sep 10, 2019

This has taken a tremendous amount of work, and it is rolling back most/all of the automatic encoding/decoding effort done in 77912c0

In addition to the removal, I am making sure that

  • previous tests are passing almost without modifying
  • new functional tests demonstrate the problem and ensure the fix (need hooks into the CI though)
  • adds a fallback when all fails with the logging module
  • adds tests that verify that the logging module is used when encoding/decoding is failing

This PR should not be definite, and there should be new work put into place to fully remove the custom terminal logging so that the logging module is used instead. Since it is critical to have this fixed right away, my intention is to move this forward all the way to luminous and then start thinking about a proper solution to the terminal logging problem.

Fixes: https://tracker.ceph.com/issues/41660
Backport of: #30274

alfredodeza added 7 commits Sep 9, 2019
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 4612ab3)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 95b16b5)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit bfb8422)
This caused problems in environments where stderr was redirected, since
stderr sets the encoding to None. Getting it back again allows
everything to work correctly, and keeps all the current unit tests
passing

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit fe66e01)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit ee18ebc)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 595e492)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 7919635)
@alfredodeza alfredodeza requested a review from jan--f Sep 10, 2019
@alfredodeza alfredodeza added this to the nautilus milestone Sep 10, 2019
@smithfarm smithfarm changed the title nautilus ceph-volume: fix stderr failure to decode/encode when redirected nautilus: ceph-volume: fix stderr failure to decode/encode when redirected Sep 10, 2019
@jan--f
jan--f approved these changes Sep 11, 2019
Copy link
Member

left a comment

lgtm

@alfredodeza alfredodeza merged commit 9681ad4 into ceph:nautilus Sep 11, 2019
5 checks passed
5 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume tox testing ceph-volume tox OK
Details
make check make check succeeded
Details
@alfredodeza alfredodeza deleted the alfredodeza:nautilus-rm41660 branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.