Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: fix stderr failure to decode/encode when redirected #30301

Merged
merged 7 commits into from Sep 12, 2019

Conversation

@alfredodeza
Copy link
Contributor

alfredodeza commented Sep 10, 2019

This has taken a tremendous amount of work, and it is rolling back most/all of the automatic encoding/decoding effort done in 77912c0

In addition to the removal, I am making sure that

  • previous tests are passing almost without modifying
  • new functional tests demonstrate the problem and ensure the fix (need hooks into the CI though)
  • adds a fallback when all fails with the logging module
  • adds tests that verify that the logging module is used when encoding/decoding is failing

This PR should not be definite, and there should be new work put into place to fully remove the custom terminal logging so that the logging module is used instead. Since it is critical to have this fixed right away, my intention is to move this forward all the way to luminous and then start thinking about a proper solution to the terminal logging problem.

Fixes: https://tracker.ceph.com/issues/41660
Backport of: #30274

alfredodeza added 7 commits Sep 9, 2019
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 4612ab3)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 95b16b5)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit bfb8422)
This caused problems in environments where stderr was redirected, since
stderr sets the encoding to None. Getting it back again allows
everything to work correctly, and keeps all the current unit tests
passing

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit fe66e01)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit ee18ebc)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 595e492)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 7919635)
@alfredodeza alfredodeza requested a review from jan--f Sep 10, 2019
@alfredodeza alfredodeza added this to the mimic milestone Sep 10, 2019
@jan--f

This comment has been minimized.

Copy link
Member

jan--f commented Sep 11, 2019

jenkins test ceph-volume tox

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

alfredodeza commented Sep 11, 2019

The tox tests passed, I think it is safe to merge as the failure is coming from not rebasing on the latest mimic branch:

  py27: commands succeeded
ERROR:  py35: InterpreterNotFound: python3.5
  py36: commands succeeded
  flake8: commands succeeded
@jan--f
jan--f approved these changes Sep 12, 2019
@alfredodeza alfredodeza merged commit e131432 into ceph:mimic Sep 12, 2019
3 of 5 checks passed
3 of 5 checks passed
Docs: build check Docs: failed with errors
Details
ceph-volume tox testing ceph-volume tox failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@alfredodeza alfredodeza deleted the alfredodeza:mimic-rm41660 branch Sep 12, 2019
@smithfarm smithfarm changed the title mimic ceph-volume: fix stderr failure to decode/encode when redirected mimic: ceph-volume: fix stderr failure to decode/encode when redirected Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.