Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: zap always skips block.db, leaves them around #30306

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@alfredodeza
Copy link
Contributor

alfredodeza commented Sep 10, 2019

This PR addressed two (somewhat related) problems when zapping. The first is that a typo was making the tool always skip block.db when zapping, and the other one a possible race condition when calling wipefs that can be seen when removing partitions.

I believe the latter is caused by async calls to udev so that the partition table can be re-read. The tries/intervals are using magical numbers in the sense that they are a good estimate on what I think should work, but the function is allowing further tweaking of these to prevent a situation where they are not enough.

Fixes: http://tracker.ceph.com/issues/40664
Backport of: #28998

alfredodeza added 2 commits Jul 11, 2019
…tion failures

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit b7b8b10)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit 845e62c)
@alfredodeza alfredodeza requested review from andrewschoen and jan--f Sep 10, 2019
@alfredodeza alfredodeza added this to the mimic milestone Sep 10, 2019
@jan--f
jan--f approved these changes Sep 11, 2019
@jan--f jan--f merged commit 31aa784 into ceph:mimic Sep 12, 2019
39 of 41 checks passed
39 of 41 checks passed
ceph-volume lvm testing xenial-bluestore-create failed
Details
ceph-volume tox tests failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-activate OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain OK
Details
make check make check succeeded
Details
@smithfarm smithfarm changed the title mimic ceph-volume zap always skips block.db, leaves them around mimic: ceph-volume: zap always skips block.db, leaves them around Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.