Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upmimic: ceph-volume: zap always skips block.db, leaves them around #30306
Conversation
jan--f
merged commit 31aa784
into
ceph:mimic
39 of 41 checks passed
39 of 41 checks passed
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alfredodeza commentedSep 10, 2019
This PR addressed two (somewhat related) problems when zapping. The first is that a typo was making the tool always skip
block.dbwhen zapping, and the other one a possible race condition when callingwipefsthat can be seen when removing partitions.I believe the latter is caused by async calls to
udevso that the partition table can be re-read. The tries/intervals are using magical numbers in the sense that they are a good estimate on what I think should work, but the function is allowing further tweaking of these to prevent a situation where they are not enough.Fixes: http://tracker.ceph.com/issues/40664
Backport of: #28998