crimson/osd: use single-pg peering ops #30372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
added this to In progress
in crimson (moved to https://trello.com/b/lbHkWKxh/crimson)
to accommodate the change of 77ecc32 classic OSD started to use single-pg peering ops since ce05c17, and it switched over to these ops since octopus. and it's assumed that crimson-osd won't be GA until octopus+2 release, so it's not needed to support pre-octopus releases. hence "octopus" is passed to PeeringCtx's constructor. Signed-off-by: Kefu Chai <kchai@redhat.com>
classic OSD started to use single-pg peering ops since ce05c17, and it switched over to these ops since octopus. and it's assumed that crimson-osd won't be GA until octopus+2 release, so it's not needed to support pre-octopus releases. Signed-off-by: Kefu Chai <kchai@redhat.com>
we assume that crimson will GA after octopus+2, so no need to be compatible with pre-octopus releases. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-crimson-single-pg-peering
branch
from
599eb56
to
406522d
Compare
|
retest this please. |
rzarzynski
approved these changes
Sep 13, 2019
tchaikov
moved this from In progress
to Done
in crimson (moved to https://trello.com/b/lbHkWKxh/crimson)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also #29820
Show available Jenkins commands
jenkins retest this pleasejenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docs