Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: rbd/tests: avoid hexdump skip and length options in krbd test #30569
On Debian-based distros, hexdump(1) comes from FreeBSD in bsdmainutils package (other distros ship a Linux version from util-linux). It turns out that '-s skip' for anything but a regular file has been broken for ages in FreeBSD -- instead of calling fseek(), it consumed the input byte by byte with getchar(). This was fixed in commit 7cd5ae492557 "hexdump(1): Speed up -s flag on devices" last year, but it hasn't made it to the Debian world yet. bsdmainutils_9.0.6ubuntu3 in xenial had a custom patch for that, but it's no longer there in bsdmainutils_11.1.2ubuntu1 in bionic. hexdump -s <large offset> is now a fancy infinite loop! Signed-off-by: Ilya Dryomov <email@example.com> (cherry picked from commit d1b6913)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.