Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: build/ops: admin/build-doc: use python3 #30663

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Oct 1, 2019

backport tracker: https://tracker.ceph.com/issues/42104


ceph/ceph-build#1357 broke the docs: build check for PRs targeting mimic - see #29766

backporting this commit fixes the issue

to address sphinx-doc/sphinx#3620, we need to
use sphinx with its fix at
sphinx-doc/sphinx@e049f86
in other words, we need to use sphinx v2.0.0 and up. but sphinx 2.0
requires python >= 3.5, so we have to use python3 for building the
documents.

in this change:

* doc-requirements.txt: install python3 packages on debian derivatives
* build-doc: install python3.6 packages from EPEL7, and use python3
  venv for using sphinx2
* doc-requirements.txt: bump up all python packages to latest
  stable.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit ace8cb1)

Conflicts:
	admin/doc-requirements.txt
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 1, 2019

CMake Error at cmake/modules/BuildDPDK.cmake:61 (message):
  not able to build DPDK support: unsupported target.
  "x86_64-native-linuxapp-gcc" not listed in
Call Stack (most recent call first):
  cmake/modules/BuildDPDK.cmake:83 (do_build_dpdk)
  cmake/modules/BuildSPDK.cmake:4 (build_dpdk)
  CMakeLists.txt:242 (build_spdk)


-- Configuring incomplete, errors occurred!
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 1, 2019

jenkins test make check

Copy link
Contributor

tchaikov left a comment

thanks for fixing this!

@smithfarm smithfarm merged commit 4e0b53e into ceph:mimic Oct 1, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-fix-docs-build-check-mimic branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.