Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: build/ops: admin/build-doc: use python3 (follow-on fix) #30687

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Oct 2, 2019

Unfortunately, a512731 (first attempt to
cherry-pick ace8cb1) was incomplete.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(partial manual cherry-pick of ace8cb1)
@smithfarm smithfarm added this to the mimic milestone Oct 2, 2019
@smithfarm smithfarm added the build/ops label Oct 2, 2019
@smithfarm smithfarm changed the title mimic: admin/build-doc: use python3 mimic: build/ops: admin/build-doc: use python3 Oct 2, 2019
@smithfarm smithfarm requested a review from tchaikov Oct 2, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 2, 2019

@tchaikov Somehow I missed a line in #30663

See Docs: build check failures in #29765

@tchaikov tchaikov changed the title mimic: build/ops: admin/build-doc: use python3 mimic: admin/build-doc: use python3 Oct 2, 2019
@smithfarm smithfarm changed the title mimic: admin/build-doc: use python3 mimic: build/ops: admin/build-doc: use python3 Oct 2, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 2, 2019

@tchaikov Thanks for the review. Allow me to explain why I edit the PR titles, perhaps in ways you don't agree with. When a point release is to be published, we use a script to generate the release notes. The release note entry for each PR comes from the PR title. It looks much better when the PR titles are organized by component (and "admin" is not a Ceph component).

See, e.g., https://ceph.io/releases/v14-2-3-nautilus-released/#changelog (caveat - it's not perfect, and obviously there can be different opinions on how the PRs should be presented :-)

@smithfarm smithfarm merged commit f264e85 into ceph:mimic Oct 2, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-42104-mimic branch Oct 2, 2019
@smithfarm smithfarm changed the title mimic: build/ops: admin/build-doc: use python3 mimic: build/ops: admin/build-doc: use python3 (follow-on fix) Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.