Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: build/ops: cmake: detect armv8 crc and crypto feature using CHECK_C_COMPILER_FLAG #30713
we are using GCC7 and up for C++17 support since mimic, and per https://gcc.gnu.org/onlinedocs/gcc-4.9.1/gcc/AArch64-Options.html , GCC 4.9 and up should be able to support crc and crypto features if these archs are enabled at GCC's configure-time. so we should always use the -march for detecting the compiler's support instead of using the inline assembly now. GCC 4.8 is an ancient compiler, and per https://gcc.gnu.org/gcc-4.8/changes.html, it was the the first GCC release which offers AArch64 support. so we don't need to cater for this GCC version. and we can trust GCC-7 and up. Fixes: http://tracker.ceph.com/issues/17516 Signed-off-by: Kefu Chai <email@example.com> (cherry picked from commit 010edc0)
1 similar comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.