Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: build/ops: cmake: detect armv8 crc and crypto feature using CHECK_C_COMPILER_FLAG #30713

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Oct 3, 2019

we are using GCC7 and up for C++17 support since mimic, and per
https://gcc.gnu.org/onlinedocs/gcc-4.9.1/gcc/AArch64-Options.html ,
GCC 4.9 and up should be able to support crc and crypto features if
these archs are enabled at GCC's configure-time. so we should always use
the -march for detecting the compiler's support instead of using the
inline assembly now.

GCC 4.8 is an ancient compiler, and per
https://gcc.gnu.org/gcc-4.8/changes.html, it was the the first GCC
release which offers AArch64 support. so we don't need to cater for
this GCC version. and we can trust GCC-7 and up.

Fixes: http://tracker.ceph.com/issues/17516
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 010edc0)
@smithfarm smithfarm added this to the mimic milestone Oct 3, 2019
@smithfarm smithfarm added the build/ops label Oct 3, 2019
@smithfarm smithfarm requested review from dmick, tchaikov and jdurgin Oct 3, 2019
@jdurgin
jdurgin approved these changes Oct 3, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 17, 2019

1 similar comment
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 17, 2019

@yuriw yuriw merged commit 246e303 into ceph:mimic Oct 21, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm changed the title mimic: cmake: detect armv8 crc and crypto feature using CHECK_C_COMPILER_FLAG mimic: build/ops: cmake: detect armv8 crc and crypto feature using CHECK_C_COMPILER_FLAG Oct 22, 2019
@smithfarm smithfarm deleted the smithfarm:wip-40258-mimic branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.