Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: librbd: properly handle potential object map failures #30796
Remove the "ceph_assert" statements and instead bubble any potential error code up to the caller. The object map state machines should attempt to return a 0 upon failure unless it was unable to flag the object map as invalid. Fixes: http://tracker.ceph.com/issues/36074 Signed-off-by: Jason Dillaman <firstname.lastname@example.org> (cherry picked from commit 765f8ce) Conflicts: src/librbd/DeepCopyRequest.cc: trivial resolution src/librbd/deep_copy/ObjectCopyRequest.cc: trivial resolution src/librbd/deep_copy/SnapshotCopyRequest.cc: trivial resolution src/librbd/exclusive_lock/PostAcquireRequest.cc: trivial resolution src/librbd/exclusive_lock/PreReleaseRequest.cc: trivial resolution src/librbd/image/RefreshRequest.cc: trivial resolution src/librbd/io/CopyupRequest.cc: trivial resolution src/librbd/io/ObjectRequest.cc: trivial resolution src/librbd/object_map/InvalidateRequest.cc: trivial resolution src/librbd/object_map/RefreshRequest.cc: trivial resolution src/librbd/object_map/SnapshotRemoveRequest.cc: trivial resolution src/librbd/operation/ResizeRequest.cc: trivial resolution src/librbd/operation/SnapshotCreateRequest.cc: trivial resolution src/librbd/operation/SnapshotRollbackRequest.cc: trivial resolution
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.