Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: PVolumes.filter shouldn't purge itself #30806

Merged
merged 3 commits into from Oct 18, 2019

Conversation

@jan--f
Copy link
Member

jan--f commented Oct 9, 2019

backport tracker: https://tracker.ceph.com/issues/42235


backport of #30703
parent tracker: https://tracker.ceph.com/issues/42170

this backport was staged using ceph-backport.sh version 15.0.0.5775
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 384aaee)
PVolumes.filter removes the PVs that do not match the filters from its
list. This approach is problematic since the code calling this method
has to create a copy beforehand. Therefore, it's better to return a new
object that contains PVs that matches the filters.

Fixes: https://tracker.ceph.com/issues/42170
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit fcec33e)
...returns a list of filtered PVs instead of removing the items that do
not match the filters from itself.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 38ccfe0)
@jan--f jan--f added this to the mimic milestone Oct 9, 2019
@jan--f jan--f added the ceph-volume label Oct 9, 2019
@jan--f

This comment has been minimized.

Copy link
Member Author

jan--f commented Oct 11, 2019

jenkins test ceph-volume all

@jan--f jan--f requested a review from alfredodeza Oct 11, 2019
@jan--f jan--f merged commit b0b4ede into ceph:mimic Oct 18, 2019
40 checks passed
40 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type ceph-volume batch centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt ceph-volume batch centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-bluestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_explicit ceph-volume batch centos7-bluestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-bluestore-single_type ceph-volume batch centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt ceph-volume batch centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type ceph-volume batch centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt ceph-volume batch centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-filestore-mixed_type_dmcrypt_explicit OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_explicit ceph-volume batch centos7-filestore-mixed_type_explicit OK
Details
ceph-volume batch testing centos7-filestore-single_type ceph-volume batch centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt ceph-volume batch centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type ceph-volume batch xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt ceph-volume batch xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type ceph-volume batch xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt ceph-volume batch xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create ceph-volume lvm centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt ceph-volume lvm centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create ceph-volume lvm centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt ceph-volume lvm centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create ceph-volume lvm xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt ceph-volume lvm xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create ceph-volume lvm xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt ceph-volume lvm xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate ceph-volume simple centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks ceph-volume simple centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain ceph-volume simple centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate ceph-volume simple centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks ceph-volume simple centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain ceph-volume simple centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-activate ceph-volume simple xenial-bluestore-activate OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks ceph-volume simple xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain ceph-volume simple xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate ceph-volume simple xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks ceph-volume simple xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain ceph-volume simple xenial-filestore-dmcrypt_plain OK
Details
make check make check succeeded
Details
@jan--f jan--f deleted the jan--f:wip-42235-mimic branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.