Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: fix refcount tags to match and update object's idtag #30891

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Oct 14, 2019

backport tracker: https://tracker.ceph.com/issues/41715


backport of #30013
parent tracker: https://tracker.ceph.com/issues/23674

this backport was staged using ceph-backport.sh version 15.0.0.6113
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@smithfarm smithfarm added this to the mimic milestone Oct 14, 2019
@smithfarm smithfarm added the rgw label Oct 14, 2019
ivancich added 2 commits Aug 29, 2019
This change was originally submitted by lltlo <120680451@qq.com> but
had some formatting issues and wasn't signed-off.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 7d32b08)

Conflicts:
	src/rgw/rgw_rados.cc
When the refcount does a "get", the tag ends with a null character,
but during a rollback, when the tag is "put" it does not end with a
null character, so the same tag is not being manipulated and the
refcounts are therefore off, preventing future deletion of an rgw
object. This adds the null character to the "put" operation.

This change was originally submitted by lltlo <120680451@qq.com> but
wasn't signed-off.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit a0fee94)

Conflicts:
	src/rgw/rgw_rados.cc
@smithfarm smithfarm force-pushed the smithfarm:wip-41715-mimic branch from 3020ddb to b82ca3c Oct 14, 2019
@smithfarm smithfarm requested review from cbodley and ivancich Oct 14, 2019
Copy link
Member

ivancich left a comment

Thank you, @smithfarm .

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 17, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 18, 2019

@yuriw yuriw merged commit cea2e99 into ceph:mimic Oct 22, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41715-mimic branch Oct 22, 2019
yuriw added a commit that referenced this pull request Oct 22, 2019
mimic: rgw: fix refcount tags to match and update object's idtag

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.