Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: mon/OSDMonitor: trim not-longer-exist failure reporters #30903

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Oct 14, 2019

backport tracker: https://tracker.ceph.com/issues/42154


backport of #30200
parent tracker: https://tracker.ceph.com/issues/41680

this backport was staged using ceph-backport.sh version 15.0.0.6113
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@smithfarm smithfarm added this to the mimic milestone Oct 14, 2019
@smithfarm smithfarm added the core label Oct 14, 2019
@smithfarm smithfarm requested review from tchaikov and neha-ojha Oct 14, 2019
src/mon/OSDMonitor.cc Outdated Show resolved Hide resolved
remove the report from failure_info in OSDMonitor::check_failure(), if
the reporter does not exist in the osdmap any longer. otherwise, we will
run into assert() failure when trying to lookup the osd in osdmap using
`osdmap.get_xinfo()`.

Fixes: https://tracker.ceph.com/issues/41680
Signed-off-by: NancySu05 <su_nan@inspur.com>
(cherry picked from commit 99ccc16)

Conflicts:
	src/mon/OSDMonitor.cc
- ceph_assert, g_conf()
@smithfarm smithfarm force-pushed the smithfarm:wip-42154-mimic branch from 7b500ab to 4e54d42 Oct 15, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 15, 2019

jenkins test docs

1 similar comment
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 15, 2019

jenkins test docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 15, 2019

@tchaikov Thanks. Should be good now?

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 17, 2019

@yuriw yuriw merged commit ec096ed into ceph:mimic Oct 21, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm changed the title mimic: mon/OSDMonitor: trim not-longer-exist failure reporters mimic: core: mon/OSDMonitor: trim not-longer-exist failure reporters Oct 22, 2019
@smithfarm smithfarm deleted the smithfarm:wip-42154-mimic branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.