Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mds: Fix duplicate client entries in eviction list #30950

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@sidharthanup
Copy link
Contributor

sidharthanup commented Oct 16, 2019

Fix duplicate client entries in list to avoid multiple client evictions.

Backport Tracker: https://tracker.ceph.com/issues/41885


Backport of: #30029

parent tracker: https://tracker.ceph.com/issues/41585

@sidharthanup sidharthanup requested a review from batrick Oct 16, 2019
@sidharthanup sidharthanup added the cephfs label Oct 16, 2019
@sidharthanup sidharthanup force-pushed the sidharthanup:mds-evict-duplicate-mimic branch 2 times, most recently from 50f048e to 8f23ba2 Oct 16, 2019
@sidharthanup sidharthanup added this to the mimic milestone Oct 17, 2019
@smithfarm smithfarm changed the title mimic:mds: Fix duplicate client entries in eviction list mimic: mds: Fix duplicate client entries in eviction list Oct 17, 2019
@smithfarm smithfarm self-requested a review Oct 17, 2019
Copy link
Contributor

smithfarm left a comment

There are some formal requirements for backports. One of them says that a backport that cannot be cherry-picked from master should state, in the commit message, why it cannot be cherry-picked.

So, please add a sentence to that effect to the commit message. Also, you can drop the prefix "mimic:" from the commit title. It is only needed in the PR title.

Thanks!

@sidharthanup sidharthanup force-pushed the sidharthanup:mds-evict-duplicate-mimic branch from 8f23ba2 to eaf9558 Oct 18, 2019
@sidharthanup

This comment has been minimized.

Copy link
Contributor Author

sidharthanup commented Oct 18, 2019

@smithfarm Sorry about that. Fixed it!

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 18, 2019

jenkins test submodules

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 18, 2019

@sidharthanup Since this is a manual backport of f4afb43 could you please add the following line after the Signed-off-by line:

(manual backport of f4afb43f3649161516f2350df9fd1d918b13736b)
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 18, 2019

Please also include the original Fixes line:

Fixes: https://tracker.ceph.com/issues/41585
…ictions

Cannot be cherry-picked from master because the container to be changed that's being used in mimic is std::list instead of std::vector

Fixes: https://tracker.ceph.com/issues/41585
Signed-off-by: Sidharth Anupkrishnan <sanupkri@redhat.com>
(manual backport of f4afb43)
@sidharthanup sidharthanup force-pushed the sidharthanup:mds-evict-duplicate-mimic branch from eaf9558 to 41dc60a Oct 18, 2019
@sidharthanup

This comment has been minimized.

Copy link
Contributor Author

sidharthanup commented Oct 18, 2019

@smithfarm Updated

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 18, 2019

jenkins test submodules

@smithfarm smithfarm dismissed their stale review Oct 18, 2019

commit message LGTM

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 21, 2019

jenkins test submodules

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 22, 2019

@yuriw yuriw merged commit 7738ab8 into ceph:mimic Oct 29, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.