Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: tools: ceph-objectstore-tool: update-mon-db: do not fail if incmap is missing #30979

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Oct 17, 2019

backport tracker: https://tracker.ceph.com/issues/41464


backport of #29571
parent tracker: https://tracker.ceph.com/issues/41177

this backport was staged using ceph-backport.sh version 15.0.0.6113
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

there is chance that we could use an OSD which does not have incmap of a
certain epoch for rebuilding the monstore. and since OSD does not read
and store the incmap if the MOSDMap message already has the fullmap of
that fullmap, and if an OSD does not have previous fullmap, monitor
will just send it the fullmao. so it's not unusual that an OSD has
a fullmap of some epoch without corresponding incmap.

Fixes: https://tracker.ceph.com/issues/41177
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 2e2414b)
@smithfarm smithfarm added this to the mimic milestone Oct 17, 2019
@smithfarm smithfarm added the tools label Oct 17, 2019
@smithfarm smithfarm changed the title mimic: ceph-objectstore-tool: update-mon-db: do not fail if incmap is missing mimic: tools: ceph-objectstore-tool: update-mon-db: do not fail if incmap is missing Oct 17, 2019
@smithfarm smithfarm requested review from tchaikov and neha-ojha Oct 17, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 18, 2019

jenkins test docs

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 21, 2019

@yuriw yuriw merged commit 4541d67 into ceph:mimic Oct 23, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-41464-mimic branch Oct 23, 2019
@neha-ojha

This comment has been minimized.

Copy link
Member

neha-ojha commented Nov 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.