Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: do necessary checking of website configuration #30980

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Oct 17, 2019

backport tracker: https://tracker.ceph.com/issues/41496


backport of #28904
parent tracker: https://tracker.ceph.com/issues/40678

this backport was staged using ceph-backport.sh version 15.0.0.6113
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

ZVampirEM77 added 2 commits Jul 5, 2019
…guration

Fixes: http://tracker.ceph.com/issues/40678

Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
(cherry picked from commit 355f392)

Conflicts:
	src/rgw/rgw_rest_s3.cc
- 3275dff is not being backported
Currently, if the index_doc_suffix is empty which is leaded
by the IndexDocument field is not configurated or is set to
empty string during enabling bucket website function, the
rgw will crash when accessing the static website through the
S3Website enabled RGW instance.

In actually, we have add the necessary checking in the commit
355f392, but double checking
in here is better.

Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
(cherry picked from commit c96f415)

Conflicts:
	src/rgw/rgw_rest_s3.cc
- ldpp_dout
@smithfarm smithfarm added this to the mimic milestone Oct 17, 2019
@smithfarm smithfarm added the rgw label Oct 17, 2019
@smithfarm smithfarm requested a review from cbodley Oct 17, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 17, 2019

@cbodley Is the luminous backport of this fix really necessary?

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Oct 18, 2019

jenkins test docs

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 18, 2019

@yuriw yuriw merged commit 9fcabe6 into ceph:mimic Oct 22, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm changed the title mimic: rgw: fix the bug of rgw not doing necessary checking to website configuration mimic: rgw: not doing necessary checking of website configuration Oct 22, 2019
@smithfarm smithfarm changed the title mimic: rgw: not doing necessary checking of website configuration mimic: rgw: do necessary checking of website configuration Oct 22, 2019
@smithfarm smithfarm deleted the smithfarm:wip-41496-mimic branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.