Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: fix rbd_features_to_string output #31006

Merged
merged 1 commit into from Oct 25, 2019

Conversation

zhengchengyao
Copy link
Contributor

if features = 61, it will output ",deep-flattenexclusive-lockfast-difflayeringobject-map".
I think "deep-flatten,exclusive-lock,fast-diff,layering,object-map" is suitable output.

Signed-off-by: Zheng Yin zhengyin@cmss.chinamobile.com

@zhengchengyao zhengchengyao force-pushed the fix_features branch 2 times, most recently from 6c6bde6 to 2deb39c Compare October 21, 2019 09:37
if features = 61, it will output ",deep-flattenexclusive-lockfast-difflayeringobject-map".
I think "deep-flatten,exclusive-lock,fast-diff,layering,object-map" is suitable output.

Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method even used anywhere?

@zhengchengyao
Copy link
Contributor Author

Is this method even used anywhere?

Hi,dillaman ,I will use this method in my another commit about rbd_features_to_string librbd API.

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhengchengyao
Copy link
Contributor Author

jenkins test make check

@dillaman dillaman merged commit 190b0bf into ceph:master Oct 25, 2019
@zhengchengyao zhengchengyao deleted the fix_features branch October 28, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants