mimic: mgr/prometheus: Cast collect_timeout (scrape_interval) to float #31108
If set by user scrape_interval option is returned as non-float by get_localized_module_option. Metric cache timeout comparison always returns true and data is never refreshed. Fixes: https://tracker.ceph.com/issues/40997 Signed-off-by: Ben Meekhof <firstname.lastname@example.org> (cherry picked from commit 26a74a0) Conflicts: - path: src/pybind/mgr/prometheus/module.py comment: get_localized_module_option() in master, get_localized_config() in mimic
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.