Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: add Ceph's device id to inventory #31211

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@sebastian-philipp
Copy link
Member

sebastian-philipp commented Oct 29, 2019

Backport of #31072

This will benefit the orchestrator and dashboard to show a unified view of devices with SMART data

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com
(cherry picked from commit e70d604)

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
This will benefit the orchestrator and dashboard to show a unified view of devices with SMART data

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
(cherry picked from commit e70d604)
@sebastian-philipp sebastian-philipp added this to the mimic milestone Oct 29, 2019
@sebastian-philipp sebastian-philipp requested a review from jan--f Oct 29, 2019
@jan--f
jan--f approved these changes Oct 29, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 31, 2019

@jan--f Which mimic release is this PR targeting: 13.2.7 (imminent) or 13.2.8?

@sebastian-philipp

This comment has been minimized.

Copy link
Member Author

sebastian-philipp commented Oct 31, 2019

8?

@jan--f

This comment has been minimized.

Copy link
Member

jan--f commented Oct 31, 2019

@smithfarm whatever works for the release time I'd say. No need to show horn it into 7 if that disturbs things, but it also wouldn't hurt.

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 31, 2019

If you're reasonably confident it won't break c-v in mimic, then I see no reason not to merge it now.

@jan--f jan--f merged commit e78341b into ceph:mimic Oct 31, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.