Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: restful: Query nodes_by_id for items #31273

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@badone
Copy link
Contributor

badone commented Oct 31, 2019

https://tracker.ceph.com/issues/42572

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
b-ranto added 2 commits Oct 24, 2019
The node dict that is passed to the _gather_leaf_ids function from the
_gather_osds function does not have 'items' in it. We also can't use
buckets at this point since those only exist for leaf nodes, not all
nodes.

We need to query the nodes_by_id dict to get 'items' for a node inside
the _gather_leaf_ids function instead.

Signed-off-by: Boris Ranto <branto@redhat.com>
(cherry picked from commit 4f17cbc)
The _gather_leaf_ids function doesn't need the node structure, it only
needs the id.

Signed-off-by: Boris Ranto <branto@redhat.com>
(cherry picked from commit a325f28)
@badone badone added this to the mimic milestone Oct 31, 2019
@badone badone requested a review from b-ranto Oct 31, 2019
@b-ranto b-ranto changed the title Wip mimic restful node items mimic: restful: Query nodes_by_id for items Oct 31, 2019
@badone badone added the needs-qa label Oct 31, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 31, 2019

@badone The 13.2.7 release is imminent and we're trying to get it ready for QE. Is this "stop the presses" urgent?

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 31, 2019

Apparently, it is. From the luminous PR:

Note: (06:05:23 PM) badone: yuriw: this one is going downstream so it would good if it gets in
@badone

This comment has been minimized.

Copy link
Contributor Author

badone commented Oct 31, 2019

Luminous is, mimic isn't.

@b-ranto

This comment has been minimized.

Copy link
Contributor

b-ranto commented Oct 31, 2019

If I understand it right, we are doing last upstream version for luminous so it would be nice to get it in. It would get us to a weird state where luminous would have the fix before mimic but I wouldn't object to that.

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 31, 2019

@yuriw yuriw merged commit 823919c into ceph:mimic Nov 4, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.