Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: osd: Fix for compatibility of encode/decode of osd_stat_t #31275

Merged
merged 2 commits into from Nov 4, 2019

Conversation

@dzafman
Copy link
Member

dzafman commented Oct 31, 2019

Fix for #30225

Pulled in #26315 to fix compiler warnings.

Fixes: https://tracker.ceph.com/issues/42570


Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
@dzafman dzafman added this to the mimic milestone Oct 31, 2019
@dzafman dzafman changed the title Wip network fix mimic: Wip network fix Oct 31, 2019
@dzafman dzafman requested a review from liewegas Oct 31, 2019
@smithfarm smithfarm changed the title mimic: Wip network fix mimic: core: osd: Fix for compatibility of encode/decode of osd_stat_t Oct 31, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 31, 2019

@dzafman When you named this PR "wip network fix" did you mean that it is a work-in-progress and @yuriw should not test it?

(I re-did the PR title to accommodate the release notes script...)

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 31, 2019

UPDATE: My guess is that this PR fixes https://tracker.ceph.com/issues/42570 and thereby replaces #31267

Correct, @liewegas ?

tchaikov and others added 2 commits Feb 7, 2019
…r printing

in GCC-9, `-Waddress-of-packed-member` is enabled, so we have warnings like:

src/msg/msg_types.h:142:41: warning: converting a packed 'const
ceph_entity_name' pointer (alignment 1) to a 'const entity_name_t'
pointer (alignment 8) may result in an unaligned pointer value
[-Waddress-of-packed-member]
  142 |   return out << *(const entity_name_t*)&addr;
      |                                         ^~~~

since the alignment of these two structures are different, we cannot
cast a structure with the alignment of 1 to a structure with the
alignment of 8. as the code generated by compiler accessing the members
of alignment 8 won't work with the members of alignment 1, we need to
create a temporary structure for printing it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit f1bfe9d)
Signed-off-by: David Zafman <dzafman@redhat.com>
@dzafman dzafman force-pushed the dzafman:wip-network-fix branch from 13985a9 to 05f8067 Oct 31, 2019
@dzafman

This comment has been minimized.

Copy link
Member Author

dzafman commented Oct 31, 2019

@smithfarm Yes, this replaces the revert (#31267)

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 31, 2019

@yuriw yuriw merged commit 835a737 into ceph:mimic Nov 4, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.