Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
mimic: core: osd: Fix for compatibility of encode/decode of osd_stat_t #31275
Fix for #30225
Pulled in #26315 to fix compiler warnings.
Show available Jenkins commands
…r printing in GCC-9, `-Waddress-of-packed-member` is enabled, so we have warnings like: src/msg/msg_types.h:142:41: warning: converting a packed 'const ceph_entity_name' pointer (alignment 1) to a 'const entity_name_t' pointer (alignment 8) may result in an unaligned pointer value [-Waddress-of-packed-member] 142 | return out << *(const entity_name_t*)&addr; | ^~~~ since the alignment of these two structures are different, we cannot cast a structure with the alignment of 1 to a structure with the alignment of 8. as the code generated by compiler accessing the members of alignment 8 won't work with the members of alignment 1, we need to create a temporary structure for printing it. Signed-off-by: Kefu Chai <firstname.lastname@example.org> (cherry picked from commit f1bfe9d)
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.