rgw: auto-clean reshard queue entries for non-existent buckets #31323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible for a bucket to be added to the reshard queue and then to be removed before its entry in the reshard queue is processed. When this is now encountered, processing of the reshard queue errors out. This fix recognizes when the reshard queue entry refers to a non-existent bucket and remove the entry from the reshard queue, allowing processing of the queue to continue. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
ivancich
force-pushed
the
wip-autoclean-reshard-long-entries
branch
from
8c156d7
to
304ad88
Compare
theanalyst
approved these changes
Nov 4, 2019
|
teuthology rgw/verify: http://pulpito.ceph.com/ivancich-2019-11-09_20:41:15-rgw-wip-eric-testing-1-distro-basic-smithi/ |
|
s3-tests shows no regressions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a bucket to be added to the reshard queue and then to be removed before its entry in the reshard queue is processed. Prior to this pr, the entry would remain on the reshard queue and stop the queue from being processed further. With this pr, the entry will be automatically removed with appropriate log entries and processing of the queue can continue.
Tracker: https://tracker.ceph.com/issues/42595