Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: qa: krbd_msgr_segments.t: filter lvcreate output #31324

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@idryomov
Copy link
Contributor

idryomov commented Nov 1, 2019

Some versions of lvm emit a log message

Using default stripesize 64.00 KiB.

which fails the test.

Signed-off-by: Ilya Dryomov idryomov@gmail.com
(cherry picked from commit 645252d)

Some versions of lvm emit a log message

  Using default stripesize 64.00 KiB.

which fails the test.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 645252d)
@idryomov idryomov added rbd tests labels Nov 1, 2019
@idryomov idryomov added this to the mimic milestone Nov 1, 2019
@idryomov

This comment has been minimized.

Copy link
Contributor Author

idryomov commented Nov 1, 2019

This was merged in the nautilus days, but the backport to mimic felt through the cracks. luminous doesn't have this test.

@idryomov idryomov changed the title qa: krbd_msgr_segments.t: filter lvcreate output mimic: qa: krbd_msgr_segments.t: filter lvcreate output Nov 6, 2019
Copy link
Contributor

dillaman left a comment

👍

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 6, 2019

@dillaman @idryomov does this require krbd ?

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 6, 2019

@idryomov

This comment has been minimized.

Copy link
Contributor Author

idryomov commented Nov 6, 2019

@yuriw I tested it myself, see #31324 (comment). Merge away ;)

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 6, 2019

@idryomov cool !

@yuriw yuriw merged commit e46b9f0 into ceph:mimic Nov 6, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@idryomov idryomov deleted the idryomov:wip-krbd-lvcreate-args-mimic branch Nov 6, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Nov 7, 2019

Thanks, @idryomov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.