New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph-backport.sh: guess component with --existing-pr #31419
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/42656 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: https://tracker.ceph.com/issues/42657 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
A user did "ceph-backport.sh --setup" and entered the interactive setup routine. After entering a valid GitHub personal access token, she got the following message: ceph-backport.sh: my GitHub username is callithea ceph-backport.sh: You must provide a valid GitHub personal access token ceph-backport.sh: ERROR: problem detected in your setup ceph-backport.sh: Run "ceph-backport.sh --setup" to fix and the script aborted. This commit fixes the issue. Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes confusing error message reported by a user: Setup step 3 of 4 - remote repos --------------------------------------------------------------------- Searching "git remote -v" for remote repos ceph-backport.sh: ERROR: Cannot auto-determine fork remote ceph-backport.sh: (Could not find GitHub user callithea's fork of ceph/ceph in "git remote -v") ceph-backport.sh: ERROR: (internal error) fork_remote not set, even after completing Steps 1-3 of interactive setup ceph-backport.sh: This could be reported as a bug! Signed-off-by: Nathan Cutler <ncutler@suse.com>
callithea
approved these changes
Nov 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it, works for me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/42656
Fixes: https://tracker.ceph.com/issues/42657