Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: tests: make get_mon_status use mon addr #31461

Merged
merged 3 commits into from Nov 8, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Nov 7, 2019

Follow-on fix for #31424 which was itself a follow-on fix for #30841

Fixes: https://tracker.ceph.com/issues/42658

liewegas and others added 2 commits Dec 19, 2018
We don't have the 'mon addr' config property any more.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit ac2430a)
We don't have the 'mon addr' config property any more.

This commit cannot be cherry-picked from master because qa/tasks/mon_seesaw.py
was dropped in nautilus.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm smithfarm added the tests label Nov 7, 2019
@smithfarm smithfarm added this to the mimic milestone Nov 7, 2019
@smithfarm smithfarm requested review from liewegas, dillaman and neha-ojha Nov 7, 2019
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 545df76)
Copy link
Contributor

dillaman left a comment

lgtm

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Nov 7, 2019

99% tests passed, 1 tests failed out of 157

Total Test time (real) = 1003.74 sec

The following tests FAILED:
	 64 - unittest_throttle (Failed)
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Nov 7, 2019

jenkins test make check

@smithfarm smithfarm requested a review from yuriw Nov 7, 2019
@smithfarm smithfarm added the core label Nov 7, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Nov 7, 2019

@yuriw One more rados suite for this PR and then start QE on mimic?

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 7, 2019

@smithfarm smithfarm requested a review from cbodley Nov 7, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

smithfarm commented Nov 7, 2019

Yeah, upon hindsight #30841 was probably a bad idea...

@smithfarm

This comment has been minimized.

@yuriw
yuriw approved these changes Nov 8, 2019
@yuriw yuriw merged commit d203ae4 into ceph:mimic Nov 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm smithfarm deleted the smithfarm:wip-fix-get-mons-mimic2 branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.