rgw: find oldest period and update RGWMetadataLogHistory() #31873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
reviewed
Nov 26, 2019
smanjara
force-pushed
the
wip-mdlog-crash
branch
from
caa8b3a
to
6e95f28
Compare
cbodley
approved these changes
Dec 2, 2019
|
jenkins retest make check |
|
jenkins test make check |
|
@smanjara do we have a tracker issue for backports? |
yes, just opened one. https://tracker.ceph.com/issues/43134 |
|
Can you put the line: directly in the commit message? That way, it will be in the actual git history instead of just here in github. |
find the oldest one and update RGWMetadataLogHistory. This is to avoid an empty cursor being passed in to ceph_assert() in PurgePeriodLogsCR::operate() in case of incomplete period history. Fixes: https://tracker.ceph.com/issues/40341 Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
smanjara
force-pushed
the
wip-mdlog-crash
branch
from
6e95f28
to
0ea65d8
Compare
Sure, added to commit message. Thanks. |
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
|
@smanjara can you please run this through qa? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a period lookup for oldest_realm_epoch returns an ENOENT,
find the oldest one and update RGWMetadataLogHistory. This is to avoid an
empty cursor being passed in to ceph_assert() in PurgePeriodLogsCR::operate()
in case of incomplete period history.
Signed-off-by: Shilpa Jagannath smanjara@redhat.com
Fixes: https://tracker.ceph.com/issues/40341
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox