Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: osd: fix sending incremental map messages (more) #32000

Merged
merged 3 commits into from Dec 5, 2019

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Dec 4, 2019

Fixes an issue in 13.2.7 reported by @dvanders at https://tracker.ceph.com/issues/43106

backport tracker: https://tracker.ceph.com/issues/43119


backport of #26448
parent tracker: https://tracker.ceph.com/issues/38330

this backport was staged using ceph-backport.sh version 15.0.0.6950
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

liewegas added 3 commits Feb 15, 2019
… incremental

Fixes 47a3f63 and
follow-on 57a13ad

Fixes: http://tracker.ceph.com/issues/38330
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit e861f03)
If we are building a history and are missing an incremental, continue with
a full map in its place.

Generally speaking, an OSD should *always* have a full map stored, but
may not have the corresponding incremental for various reasons.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit b43ee7b)
We may receive a message that sat in a queue for a while with a low
priority and is tagged with an older epoch.  Don't send a bunch of old
maps that we have already sent the peer.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit fa58979)
@smithfarm smithfarm added this to the mimic milestone Dec 4, 2019
@smithfarm smithfarm added the core label Dec 4, 2019
@smithfarm smithfarm requested a review from neha-ojha Dec 4, 2019
@dvanders

This comment has been minimized.

Copy link
Contributor

dvanders commented Dec 4, 2019

We built with the cherry picks from the source of this backport already and our OSDs are no longer crashing.

@liewegas liewegas added the needs-qa label Dec 4, 2019
@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Dec 4, 2019

@theanalyst @smithfarm let's do a quick mimic with this?

@neha-ojha

This comment has been minimized.

Copy link
Member

neha-ojha commented Dec 4, 2019

@theanalyst @smithfarm let's do a quick mimic with this?

+1 , FYI @yuriw

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Dec 4, 2019

@yuriw yuriw merged commit 5b08aff into ceph:mimic Dec 5, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.