New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph.spec.in: move distro-conditional deps to dedicated section #32080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
requested review from
tchaikov,
LenzGr,
toabctl,
ktdreyer,
badone and
sebastian-philipp
December 6, 2019 13:55
badone
previously approved these changes
Dec 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@smithfarm Maybe submit this to shaman (if you haven't already) and paste the link as a form of QA? |
tchaikov
requested changes
Dec 9, 2019
badone
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tchaikov
approved these changes
Dec 11, 2019
Post e92cb7a cleanup. Restore previous structure of "distro-conditional make check dependencies" section. Fixes: https://tracker.ceph.com/issues/43171 Signed-off-by: Nathan Cutler <ncutler@suse.com>
tchaikov
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post e92cb7a cleanup. Restore previous
structure of "distro-conditional make check dependencies" section.
Fixes: https://tracker.ceph.com/issues/43171
Signed-off-by: Nathan Cutler ncutler@suse.com