Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph.spec.in: move distro-conditional deps to dedicated section #32080

Merged
merged 1 commit into from Dec 12, 2019

Conversation

smithfarm
Copy link
Contributor

Post e92cb7a cleanup. Restore previous
structure of "distro-conditional make check dependencies" section.

Fixes: https://tracker.ceph.com/issues/43171
Signed-off-by: Nathan Cutler ncutler@suse.com

badone
badone previously approved these changes Dec 6, 2019
Copy link
Contributor

@badone badone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badone
Copy link
Contributor

badone commented Dec 6, 2019

@smithfarm Maybe submit this to shaman (if you haven't already) and paste the link as a form of QA?

ceph.spec.in Outdated Show resolved Hide resolved
ceph.spec.in Show resolved Hide resolved
@smithfarm
Copy link
Contributor Author

@smithfarm
Copy link
Contributor Author

@tchaikov @badone Requested changes made and Shaman is all green.

Copy link
Contributor

@badone badone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ceph.spec.in Outdated Show resolved Hide resolved
Post e92cb7a cleanup. Restore previous
structure of "distro-conditional make check dependencies" section.

Fixes: https://tracker.ceph.com/issues/43171
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

https://shaman.ceph.com/builds/ceph/wip-43171/e80d14a17647c5f6e7c3c7fcc4c8bfb5c8297fcd/

@smithfarm smithfarm merged commit be25c6e into ceph:master Dec 12, 2019
@smithfarm smithfarm deleted the wip-43171 branch December 12, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants