Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix copy object urlencoding #32205

Closed
wants to merge 1 commit into from
Closed

Conversation

larrabee
Copy link

Commit ea979b9 breaks parsing of urlencoded 'copy_source' field on S3 Copy operation.
It's happen because in new version the field splitted by '/' before urldecode.
Fixes: #43259

Fixes: https://tracker.ceph.com/issues/43259
Signed-off-by: Vladimir Buyanov <kafatron@gmail.com>
@tchaikov tchaikov added the rgw label Dec 12, 2019
@dang dang added the needs-qa label Dec 19, 2019
cbodley
cbodley previously approved these changes Dec 19, 2019
Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be sufficient test coverage in swift and s3tests to tell whether this breaks anything else!

@dang dang added the wip-dang-testing Under test by dang label Jan 9, 2020
@dang
Copy link
Contributor

dang commented Jan 23, 2020

This appears to have caused test run failures:
http://pulpito.ceph.com/dang-2020-01-15_11:58:16-rgw-wip-dang-testing-distro-basic-smithi/

@dang dang removed the wip-dang-testing Under test by dang label Jan 23, 2020
@cbodley cbodley dismissed their stale review January 23, 2020 14:08

test failures

@cbodley cbodley removed the needs-qa label Jan 23, 2020
@stale
Copy link

stale bot commented Mar 23, 2020

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Mar 23, 2020
@stale
Copy link

stale bot commented Jun 21, 2020

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@stale stale bot closed this Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants