Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script/build-integration-branch: Add usage #32293

Merged

Conversation

sebastian-philipp
Copy link
Contributor

Also add a --no-date to make it possible to re-use an existing branch name

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

Also add a --no-date to make it possible to re-use an existing branch name

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that ptl-tool.py does more than this, though, so we probably don't need to get too carried away.

@sebastian-philipp
Copy link
Contributor Author

Main reason was to prevent anyone else from needing to read the source in order to use this tool

liewegas added a commit that referenced this pull request Dec 17, 2019
* refs/pull/32293/head:
	script/build-integration-branch: Add usage

Reviewed-by: Sage Weil <sage@redhat.com>
@liewegas liewegas merged commit f323941 into ceph:master Dec 17, 2019
@tchaikov
Copy link
Contributor

tchaikov commented Dec 17, 2019

$ ./src/script/build-integration-branch wip-kefu-testing
{'--help': False,
 '--no-date': False,
 '<label>': 'wip-kefu-testing'}
Traceback (most recent call last):
  File "./src/script/build-integration-branch", line 44, in <module>
    branch = label if arguments['--no-date'] else label + prefix
NameError: name 'prefix' is not defined

fixed by #32303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants