Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: iSCSI targets not available if any gateway is down (and more...) #32304

Merged
merged 4 commits into from Feb 6, 2020

Conversation

ricardoasmarques
Copy link
Contributor

@ricardoasmarques ricardoasmarques commented Dec 17, 2019

This backport PR contains the backport of 3 different issues.

1 - iSCSI targets not available if any gateway is down

backport tracker: https://tracker.ceph.com/issues/43333

backport of #31819
parent tracker: https://tracker.ceph.com/issues/42687


2 - Prevent deletion of iSCSI IQNs with open sessions

backport tracker: https://tracker.ceph.com/issues/43354

backport of #29133
parent tracker: https://tracker.ceph.com/issues/38332


3 - Javascript error when deleting an iSCSI target

backport tracker: https://tracker.ceph.com/issues/43355

backport of #30270
parent tracker: https://tracker.ceph.com/issues/41727


4 - Unable to remove an iSCSI gateway that is already in use

backport tracker: https://tracker.ceph.com/issues/43944

backport of #32984
parent tracker: https://tracker.ceph.com/issues/43900


this backport was staged using https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

Fixes: https://tracker.ceph.com/issues/38332

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit 0d2e150)
Fixes: https://tracker.ceph.com/issues/41727

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit ed149c2)
@ricardoasmarques ricardoasmarques added this to the nautilus milestone Dec 17, 2019
@ricardoasmarques ricardoasmarques changed the title nautilus: mgr/dashboard: iSCSI targets not available if any gateway is down nautilus: mgr/dashboard: iSCSI targets not available if any gateway is down (and more...) Dec 17, 2019
@ricardoasmarques
Copy link
Contributor Author

jenkins test make check

@smithfarm
Copy link
Contributor

119/172 Test   #5: run-tox-mgr-dashboard ...................***Failed  179.20 sec

Fixes: https://tracker.ceph.com/issues/42687

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit 1ef7fc3)

 Conflicts:
	src/pybind/mgr/dashboard/tests/test_iscsi.py

Conflicts caused by a code cleanup in ceph#26891
@callithea
Copy link
Member

jenkins test dashboard backend

@dillaman
Copy link

(rebased after nautilus branch whackiness)

@dillaman
Copy link

lgtm -- but it might make sense to also pull in #26891 so that you can have clean cherry-picks on the last commit.

@ricardoasmarques
Copy link
Contributor Author

lgtm -- but it might make sense to also pull in #26891 so that you can have clean cherry-picks on the last commit.

@dillaman Cherry-picking #26891 will cause even more conflicts, that's why I've decided to cut the chain here, instead of going deeper and deeper.

@ricardoasmarques
Copy link
Contributor Author

jenkins test make check

@ricardoasmarques
Copy link
Contributor Author

jenkins test dashboard

Copy link
Contributor

@tspmelo tspmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ricardoasmarques ricardoasmarques added nautilus-batch-1 nautilus point releases needs-qa and removed needs-review labels Jan 23, 2020
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Fixes: https://tracker.ceph.com/issues/43900

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit bcb05d0)
@ricardoasmarques
Copy link
Contributor Author

The following backport is now included in this backport PR:

@callithea
Copy link
Member

callithea commented Feb 4, 2020

@LenzGr LenzGr added the nautilus-batch-1 nautilus point releases label Feb 6, 2020
@LenzGr LenzGr merged commit 5362d0b into ceph:nautilus Feb 6, 2020
@it-is-a-robot it-is-a-robot mentioned this pull request Dec 20, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard nautilus-batch-1 nautilus point releases
Projects
None yet
7 participants