Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mon/PGMap.h: disable network stats in dump_osd_stats #32466

Merged
merged 2 commits into from Jan 6, 2020

Conversation

@neha-ojha
Copy link
Member

neha-ojha commented Jan 2, 2020

backport tracker: https://tracker.ceph.com/issues/43466
possibly a backport of #32406
parent tracker: https://tracker.ceph.com/issues/43364


original PR body:

Parent tracker: https://tracker.ceph.com/issues/43364


updated using ceph-backport.sh version 15.0.0.6950

dzafman and others added 2 commits Dec 20, 2019
…g network

Due to the overhead of this on large clusters, we removed the network
information was wasn't getting used anyway.

Fixes: https://tracker.ceph.com/issues/43364

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 1e2fe72)

 Conflicts:
	src/mon/PGMap.cc - trivial resolution
	src/mon/PGMap.h - trivial resolution
	src/osd/osd_types.h  - trivial resolution
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit ffb8a2a)

 Conflicts:
	src/mon/PGMap.h - trivial resolution
@jdurgin
jdurgin approved these changes Jan 2, 2020
Copy link
Member

jdurgin left a comment

It'd be nice to be able to stop the network stats being sent at the osd side via config option too, in case we run into a bottleneck receiving them at the mgr

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jan 3, 2020

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jan 6, 2020

CMake Error at cmake/modules/FindBoost.cmake:2170 (message):
  Unable to find the requested Boost libraries.

  Boost version: 1.72.0

  Boost include path: /opt/ceph/include

  Could not find the following Boost libraries:

          boost_python27

  Some (but not all) of the required Boost libraries were found.  You may
  need to install these additional Boost libraries.  Alternatively, set
  BOOST_LIBRARYDIR to the directory containing Boost libraries or BOOST_ROOT
  to the location of Boost.
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jan 6, 2020

jenkins test make check

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jan 6, 2020

@neha-ojha This does not pass make check due to the CMake error quoted above - my guess is that somehow the boost version for nautilus got bumped to a new one which no longer contains boost_python27.

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Jan 6, 2020

Also, I wanted to ask whether #32386 will be backported to nautilus as well?

@neha-ojha

This comment has been minimized.

Copy link
Member Author

neha-ojha commented Jan 6, 2020

@neha-ojha This does not pass make check due to the CMake error quoted above - my guess is that somehow the boost version for nautilus got bumped to a new one which no longer contains boost_python27.

hmm, not sure how that happened, I noticed this PR #32441, but it was closed.

@neha-ojha

This comment has been minimized.

Copy link
Member Author

neha-ojha commented Jan 6, 2020

Also, I wanted to ask whether #32386 will be backported to nautilus as well?

59f7115 incorporates #32386

@dzafman

This comment has been minimized.

Copy link
Member

dzafman commented Jan 6, 2020

It'd be nice to be able to stop the network stats being sent at the osd side via config option too, in case we run into a bottleneck receiving them at the mgr

@jdurgin I have an alternative fix which does dump_float() when requested, so all information can be present and most likely the performance issues will be gone in that non-user facing mode.

@wjwithagen

This comment has been minimized.

Copy link
Contributor

wjwithagen commented Jan 6, 2020

@neha-ojha This does not pass make check due to the CMake error quoted above - my guess is that somehow the boost version for nautilus got bumped to a new one which no longer contains boost_python27.

hmm, not sure how that happened, I noticed this PR #32441, but it was closed.

I'm not commenting on other things that might have happened.
But on average the Cmake will only find new Boost stuff if FindBoost.cmake supports that new version. Which is why I or @tchaikov commit a more recent version, as soon as either a Linux Distro or FreeBSD needs it. And I know that the version for 1.72 was commited to master in #32391.
But that PR does not have a fixes: tracker, and it does more that just backport FindBoost.cmake
So I guess it is not backported, and cherry-picking be192fb would be enough.

@yuriw yuriw merged commit fbfd30b into ceph:nautilus Jan 6, 2020
3 of 4 checks passed
3 of 4 checks passed
make check make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jan 9, 2020

@smithfarm i prepared #32441. it's not absolutely necessary. but it helps to silence the warnings spit by FindBoost.cmake and we only need to work with a single version of boost.

the FTBFS failure on bionic build slaves is due to we were using a pre-compiled libboost which only support python3. but i recompiled libboost with both python2 and python3 support enabled and uploaded the packages to chacra. hopefully, this should address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.