Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Centos ceph-deploy's python dependencies #32591

Merged
merged 1 commit into from Jan 10, 2020

Conversation

CypressXt
Copy link
Contributor

Documentation: Centos ceph-deploy's python dependencies

Following the current documentation on a freshly installed Centos system leads to a missing python module dependency:

[clement@ceph0 cluster]$ ceph-deploy new ceph0
Traceback (most recent call last):
  File "/usr/bin/ceph-deploy", line 18, in <module>
    from ceph_deploy.cli import main
  File "/usr/lib/python2.7/site-packages/ceph_deploy/cli.py", line 1, in <module>
    import pkg_resources
ImportError: No module named pkg_resources

This issue can be solved by installing python-setuptools.

Fixes: https://tracker.ceph.com/issues/43545
Signed-off-by: Clément Hampaï clement.hampai@cypressxt.net

@sebastian-philipp
Copy link
Contributor

Thanks for your contribution. I've just a two comments:

  1. the commit still misses a DCO:
    git checkout patch-1
    git commit --amend -s
    git push -f
    
    should be enough here.
  2. Did you had a look at cephadm already for Octopus? ceph-deploy won't be the preferred way to install Ceph in the future.

@CypressXt
Copy link
Contributor Author

Hey @sebastian-philipp, thanks for these two comments:

  • The 1. should be okay now.
  • For the point 2. yep I do thanks for pointing this. Should I push this commit to the Nautilus branch instead ?

@sebastian-philipp
Copy link
Contributor

to get this into Nautilus, you'll going to need to create a tracker issue in tracker.ceph.com and add a Fixes http://tracker.... to your commit.

@CypressXt
Copy link
Contributor Author

to get this into Nautilus, you'll going to need to create a tracker issue in tracker.ceph.com and add a Fixes http://tracker.... to your commit.

Yep it's already in it right ?
https://tracker.ceph.com/issues/43545

@sebastian-philipp
Copy link
Contributor

to get this into Nautilus, you'll going to need to create a tracker issue in tracker.ceph.com and add a Fixes http://tracker.... to your commit.

Yep it's already in it right ?
https://tracker.ceph.com/issues/43545

perfect. just amend your commit message again and add

Fixes: https://tracker.ceph.com/issues/43545

Fixes: https://tracker.ceph.com/issues/43545

Signed-off-by: Clément Hampaï <clement.hampai@cypressxt.net>
@CypressXt
Copy link
Contributor Author

Done, tracker issue added to the commit

Copy link
Contributor

@alfredodeza alfredodeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if ceph-deploy stops being the preferred method of installation in the future it is still present today, and this is a valid change.

@alfredodeza alfredodeza merged commit e2e9192 into ceph:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants