Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: #include <string> is necessary to compile with gcc10 #32614

Merged
merged 1 commit into from Jan 13, 2020
Merged

librbd: #include <string> is necessary to compile with gcc10 #32614

merged 1 commit into from Jan 13, 2020

Conversation

kalebskeithley
Copy link
Contributor

@kalebskeithley kalebskeithley commented Jan 13, 2020

#include is necessary to compile with gcc10

Fixes: https://tracker.ceph.com/issues/43456

Signed-off-by: Kaleb S. KEITHLEY kkeithle@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tchaikov
Copy link
Contributor

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it should be "librbd". also, please use the imperative mood in the commit title. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#commit-title.

Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman dillaman merged commit c7051ac into ceph:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants