New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephadm: fix logging defaults #32641
Conversation
is the stderr saved somewhere if the daemon crashes or otherwise stops? |
IIUC it goes to journald. something like
journalctl -u ceph-$fsid-$type.$id
to view?
|
confirmed |
df3e1ce
to
437ab56
Compare
Also confirmed using: |
437ab56
to
2adb2a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should document this and other differences from a non-cephadm setup in a migration doc in the future
Perhaps This would allow for access to logs even when the container is stopped/crashed:
|
- prefix stderr log lines with 'debug ' - send cluster log to stderr (only affects mons) - default to sending cluser log to stderr only (not to file) This aligns things with the container-y way, as we do with rook. It means that if you want legacy behavior (log files), you have *2* settings to change: log_to_file = true mon_cluster_log_to_file = true We could default this to leave cluster log to file by default since they aren't that big (and we do have log rotation), but it's not as clean as it could be... Signed-off-by: Sage Weil <sage@redhat.com>
2adb2a1
to
d073591
Compare
* refs/pull/32641/head: cephadm: fix logging defaults Reviewed-by: Michael Fritch <mfritch@suse.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com>
This aligns things with the container-y way, as we do
with rook. It means that if you want legacy behavior (log files),
you have 2 settings to change:
log_to_file = true
mon_cluster_log_to_file = true
We could default this to leave cluster log to file by default
since they aren't that big (and we do have log rotation), but
it's not as clean as it could be...
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard backend
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox