Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: os/bluestore/BlueStore.cc: set priorities for compression stats #32845

Merged
merged 347 commits into from Feb 10, 2020

Conversation

smithfarm
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/43245


backport of #31959
parent tracker: https://tracker.ceph.com/issues/42961

this backport was staged using ceph-backport.sh version 15.0.0.6950
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

alfonsomthd and others added 30 commits November 21, 2019 17:16
Fixes: https://tracker.ceph.com/issues/42893
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
(cherry picked from commit b5344d7)
MDS free heap space can grow to large for some workloads (like smallfile
and recursive deletes). This can cause the MDS mapped memory to grow
well beyond memory targets.

When we finally use the PriorityCache in the MDS, this will not be
necessary anymore as the PriorityCache already does this.

Fixes: https://tracker.ceph.com/issues/42938
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit af4cac5)

Conflicts:
    src/mds/MDCache.cc
The new image name in the POST data should not be URL encoded.

Fixes: https://tracker.ceph.com/issues/42785
Signed-off-by: Kiefer Chang <kiefer.chang@suse.com>
(cherry picked from commit b0013cd)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/shared/api/rbd.service.ts
        - Dashboard support of RBD namespace feature is not available in nautilus
… controller changes

Fixes: https://tracker.ceph.com/issues/41993

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 59a7bb2)
Snapshot existence validation code was removed from krbd.  It was racy
and relied on having watch established for snapshots.

Fixes: https://tracker.ceph.com/issues/42916
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 6fb5440)
These are unused since 1d29722 ("switch monc, daemons to use new
msgr2 auth frame exchange").  As they default to false, a confused user
might flip them to true and think that their client <-> OSD traffic is
encrypted.

The new set of options was added in c7ee66c
("auth,msg/async/ProtocolV2: negotiate connection modes").

Fixes: https://tracker.ceph.com/issues/42976
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 976d318)
Permit the existing logic for encrypton by a global master key
to take effect when a client has requested AES256 server-side encryption
with S3 managed keys, as well as SSE-KMS.

Fixes: https://tracker.ceph.com/issues/41670

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 80bffd9)
…initial monmap

Signed-off-by: Hao Xiong <hxiaong@ebay.com>
(cherry picked from commit 0c2da4b)

Conflicts:
	src/mon/MonMap.cc
- bf7490b ("mon/MonMap: add weight to
  mon_info_t") will not be backported
Fixes: https://tracker.ceph.com/issues/41776

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit 3e29221)

 Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/configuration/configuration-form/configuration-form.component.html

Conflicts caused by "Master" using Bootstrap 4, but "Nautilus" using Bootstap 3.
Fixes: https://tracker.ceph.com/issues/43027

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit c797fed)

 Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html

Conflicts caused by "Master" using Bootstrap 4, but "Nautilus" using Bootstap 3.
Remove shortcut menu (links) and add check in grafana CI script.

Fixes: https://tracker.ceph.com/issues/43091
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
(cherry picked from commit 1182073)

Conflicts:
	src/pybind/mgr/dashboard/ci/check_grafana_uids.py
        Test change not backported, as file does not exist in nautilus
Fixes: https://tracker.ceph.com/issues/43097
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
(cherry picked from commit 5ba1143)
Fixes: https://tracker.ceph.com/issues/42179

Signed-off-by: Ricardo Marques <rimarques@suse.com>
(cherry picked from commit acfd755)
Fixes: https://tracker.ceph.com/issues/42906

Signed-off-by: Ricardo Dias <rdias@suse.com>
(cherry picked from commit a97893e)
Signed-off-by: Casey Bodley <cbodley@redhat.com>
It is possible for a bucket to be added to the reshard queue and then
to be removed before its entry in the reshard queue is processed. When
this is now encountered, processing of the reshard queue errors out.

This fix recognizes when the reshard queue entry refers to a
non-existent bucket and remove the entry from the reshard queue,
allowing processing of the queue to continue.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 304ad88)

Conflicts:
	src/rgw/rgw_reshard.cc
- omit white-space change in get_bucket_info method call
The radosgw-admin tool allows admins to add buckets to the reshard log
and to cancel buckets from the reshard log. Both operations check for
the existence of the bucket before proceeding and fail for nonexistent
buckets.

It's possible, however, for an admin to add a bucket to the reshard
log and then, before the bucket is resharded, for a user to delete the
bucket. This leaves the entry in the reshard log.

Prior to this commit an attempt to use radosgw-admin to cancel the
reshard log entry would fail. With this commit it will still fail
*but* notify the user they can use the --yes-i-really-mean-it
command-line option to do it nonetheless. And if the user includes
that option, it will succeed.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 9f893a7)
So that it can be reused for other member functions that need to determine if
encoding is necessary

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 0974168)

Conflicts:
	src/rgw/rgw_rest_s3.cc
- trivial difference in white-space
Also doesn't encode "/" similar to S3

Fixes: https://tracker.ceph.com/issues/41870
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 4cae7a2)

Conflicts:
	src/rgw/rgw_rest_s3.cc
- trivial difference in white-space
Fixes: https://tracker.ceph.com/issues/42501
Signed-off-by: Zheng Yin <zhengyin@cmss.chinamobile.com>
(cherry picked from commit a85499c)
With the move of the 'bench' command to the admin socket the recv
timeout is being exceeded in testing due to the duration of the command.

Fixes: https://tracker.ceph.com/issues/42387

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
(cherry picked from commit 4dd67b9)
This reverts commit c3e2990.

This commit is not cherry-picked from master because the corresponding
master commit - 82bb83f - reverted changes
in a file - src/osd/PeeringState.cc - that doesn't exist in nautilus.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
If we choose a primary that does not belong to the current up set,
and all up peers are still recoverable, then we might end up excluding
some up peer from the acting_recovery_backfill set too due to the
"want size <= pool size" constraint (since ceph#24035),
as a result of which all up peers might not get recovered in one go.

Fix by falling through any oversized want set to async recovery, which
should be able to handle it nicely.

Fixes: https://tracker.ceph.com/issues/42577
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit 22c8cda)

Conflicts:
    src/osd/PeeringState.cc
- file does not exist in nautilus; made changes manually in src/osd/PG.cc
- used dout(10) instead of psdout(10)
Fixes: https://tracker.ceph.com/issues/41799

Signed-off-by: Shen Hang <harryshen18@gmail.com>
(cherry picked from commit 387686c)
We may get into a situation where the pool stats appear to exceed the
cluster capacity.  If that happens, don't generate confusing health
messages about the target_{ratio,bytes} pool settings when they aren't
actually set at all.

Fixes: https://tracker.ceph.com/issues/42301
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 4e5c4cd)
Otherwise the mgr cannot shutdown because it waits for the pg_autoscaler
thread forever.

Fixes: https://tracker.ceph.com/issues/42640
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 372b635)
4 or 8 PGs doesn't provide much parallelism at baseline.  Start with 16
and set the floor there; that's a more reasonable number of OSDs that
will be put to work on a single pool.

Note that there is no magic number here.  At some point someone has to
tell Ceph if an empty pool should get lots of PGs across lots of devices
to get the full throughput of the cluster.  But this will be a bit less
painful/surprising for users.

Fixes: https://tracker.ceph.com/issues/42509
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 78bf924)
Fixes: https://tracker.ceph.com/issues/42862

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit e923af3)
Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
(cherry picked from commit d262ade)
It's too strict and unnecessary for asok command "scrub_path" to
assert when it checked a frozen dir's rstat, just return false instead.

Fixes: https://tracker.ceph.com/issues/42251

Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>
(cherry picked from commit 76cb4da)
ukernel and others added 17 commits January 21, 2020 17:43
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
(cherry picked from commit 4b28a4a)
This also adds a test case for has_bluestore_label.

Fixes: https://tracker.ceph.com/issues/43611

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
(cherry picked from commit 91c7f51)
nautilus: mgr/prometheus: assign a value to osd_dev_node when obj_store is not filestore or bluestore

Reviewed-by: Nathan Cutler <ncutler@suse.com>
nautilus: mgr: Balancer fixes

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
nautilus: ceph-volume: add raw (--bluestore) mode
nautilus: mgr/pg_autoscaler: implement shutdown method

Reviewed-by: Neha Ojha <nojha@redhat.com>
DNM: nautilus: mgr/pg_autoscaler: default to pg_num[_min] = 16

Reviewed-by: Neha Ojha <nojha@redhat.com>
nautilus: monitoring: wait before firing osd full alert

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
nautilus: osd: set collection pool opts on collection create, pg load

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
nautilus: mgr/dashboard: Unable to set boolean values to false when default is true

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
nautilus: mgr/dashboard: Trim IQN on iSCSI target form

Reviewed-by:  Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
nautilus: mgr/dashboard,grafana: remove shortcut menu

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
nautilus: mgr/dashboard: Standby Dashboards don't handle all requests properly

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
nautilus: librbd: diff iterate with fast-diff now correctly includes parent

Reviewed-by: Mykola Golub <mgolub@mirantis.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
nautilus: doc/ceph-volume: initial docs for zfs/inventory and zfs/api

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
nautilus: mds: add command that config individual client session

Reviewed-by: Ramana Raja <rraja@redhat.com>
To allow compression statistics to be exported by ceph-mgr and make
them appear on the dashboard.

Fixes: https://tracker.ceph.com/issues/42961
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit 0657d95)
@smithfarm smithfarm added this to the nautilus milestone Jan 24, 2020
@yuriw
Copy link
Contributor

yuriw commented Feb 8, 2020

@yuriw yuriw merged commit 66c57a0 into ceph:nautilus Feb 10, 2020
@smithfarm smithfarm deleted the wip-43245-nautilus branch February 11, 2020 21:36
@it-is-a-robot it-is-a-robot mentioned this pull request Dec 20, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet