common/bl: carry the bufferlist::_carriage over std::moves #32937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzarzynski rebase? |
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
This is pretty important for crimson as we tend to move future<bl> in a few places over the hot IO path. Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
rzarzynski
force-pushed
the
wip-bl-carry-_carriage
branch
from
664bb59
to
e68b7c8
Compare
|
@tchaikov: rebased! |
tchaikov
approved these changes
Feb 14, 2020
|
probably we can hold back until octopus is released. |
|
none of the failures is related. all of them are being fixed by pending PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two last commits improve the
bufferlistmove constructor:bufferlist::_carriagepreventing the carry the append space to new instance ofbufferlistconstructed by moving-from another one,seastar::future<ceph::bufferlist>over the IO path.Other commits are pulled just as dependency in development process. Possibly many of them could be squeezed if necessary.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox