New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nautilus: ceph-volume: fix nautilus functional tests #33391
Conversation
- name: list lvs | ||
command: "lvs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just curious about this task ? What's the purpose of this ? only printing information ?
Or should this be modified by lvscan
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per IRC conversation:
[09:22:01] jafaj: what's the goal of this task ? => https://github.com/ceph/ceph/pull/33391/files#diff-5d3680c0395e606fe2ec0c3d47fd13d9R33-R34
[09:22:59] is that for debugging purpose?
[09:24:38] guits: morning. since we create "fake nvmes" on loop devices, lvm sees a given PV on two devices. Changing lvm.conf should avoid this https://github.com/ceph/ceph/pull/33391/files#diff-6ea0c4a596b89065b807a3108550c0faR10-R21 but I have found that to be not very reliable. Rescaning can help and listing lvs is more of a logging output
[09:25:10] to immediately see if lvm got confused or if a failure is actually a failure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
It might be worth considering to add a short statement to the commit message explaining why the commit cannot be cherry-picked from master. |
This is commited straight to nautilus, as post nautilus functional tests are run on CentOS8. Signed-off-by: Jan Fajerski <jfajerski@suse.com>
825b6e2
to
d77960d
Compare
retest this please |
Signed-off-by: Jan Fajerski jfajerski@suse.com
Can wait until 14.2.8 QA is done
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard backend
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox