libcephfs/pybind: Add missing python bindings #33406

kotreshhr · 2020-02-19T07:21:27Z

libcephfs/pybind: Add missing python bindings

Fixes: https://tracker.ceph.com/issues/44171
Signed-off-by: Kotresh HR khiremat@redhat.com

Checklist

References tracker ticket
Updates documentation if necessary
Includes tests for new functionality or reproducer for bug

Show available Jenkins commands

jenkins retest this please
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard backend
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox

src/pybind/cephfs/cephfs.pyx

varshar16 · 2020-02-25T04:56:44Z

Please add tests to src/test/pybind/test_cephfs.py. And in the commit message, change Updates: 44171 to Fixes: https://tracker.ceph.com/issues/44171.

kotreshhr · 2020-03-04T12:58:45Z

Rebased and added tests to few fops. I will add tests to remaining fops and refresh

kotreshhr · 2020-03-05T21:01:47Z

Fixed pwritev/preadv issue

kotreshhr · 2020-03-11T04:40:36Z

Please add tests to src/test/pybind/test_cephfs.py. And in the commit message, change Updates: 44171 to Fixes: https://tracker.ceph.com/issues/44171.

Done

kotreshhr · 2020-03-19T13:31:43Z

@gregsfortytwo could you assign someone to review this ?

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

…_return_timeout Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

kotreshhr · 2020-04-20T13:55:52Z

@rishabh-d-dave please take a look at this patch when you find time.

rishabh-d-dave

Looks good to me. But I intend to take look again since the PR has plenty commits.

rishabh-d-dave

Except for few minor issue, looks good.

src/test/pybind/test_cephfs.py

rishabh-d-dave · 2020-05-05T15:21:51Z

Also, there are no tests for start_reclaim() and finish_recalim().

ukernel · 2020-05-06T08:44:09Z

Also, there are no tests for start_reclaim() and finish_recalim().

These function are for nfs-ganesha. maybe not export them to python bindings.

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

kotreshhr · 2020-05-21T11:40:21Z

Also, there are no tests for start_reclaim() and finish_recalim().

These function are for nfs-ganesha. maybe not export them to python bindings.

Done

rishabh-d-dave · 2020-05-25T13:32:59Z

src/test/pybind/test_cephfs.py

+    assert('pool_id' in dp_dict.keys())
+    assert('pool_name' in dp_dict.keys())
+    assert_equal(cephfs.get_pool_id(dp_dict["pool_name"]), dp_dict["pool_id"])
+    get_rep_cnt_cmd = "ceph osd pool get " + dp_dict["pool_name"] + " size"


Just a note, tests in qa/ are written with the assumption that Ceph binaries are not accessible via $PATH. But I'm not sure if we should go that way here too.

@batrick Is that the case here too ?

Just a note, tests in qa/ are written with the assumption that Ceph binaries are not accessible via $PATH. But I'm not sure if we should go that way here too.

? The workunits like qa/workunits/fs/test_python.sh assume ceph utils are in $PATH?

AFAIS, test_python.sh run test_cephfs.py and test_cephfs.py doesn't use Ceph commands yet, so it's upto us to decide.

batrick · 2020-06-12T21:10:33Z

http://pulpito.ceph.com/?branch=wip-pdonnell-testing-20200612.063208

batrick · 2020-06-12T21:15:00Z

Great work, thanks @kotreshhr !

kotreshhr requested a review from batrick February 19, 2020 07:23

kotreshhr changed the title ~~libcephfs/pybind: Add fchown, fchmod, lchown~~ libcephfs/pybind: Add missing python bindings Feb 19, 2020

kotreshhr force-pushed the libcephfs-pybind-1 branch 3 times, most recently from b7b3cfe to 8ea41ee Compare February 20, 2020 14:31

batrick reviewed Feb 20, 2020

View reviewed changes

src/pybind/cephfs/cephfs.pyx Outdated Show resolved Hide resolved

kotreshhr force-pushed the libcephfs-pybind-1 branch from 8ea41ee to d23f9d9 Compare February 20, 2020 14:53

batrick added cephfs Ceph File System needs-review pybind labels Feb 21, 2020

kotreshhr force-pushed the libcephfs-pybind-1 branch 5 times, most recently from 937f14c to 38969b9 Compare March 3, 2020 06:27

kotreshhr force-pushed the libcephfs-pybind-1 branch from 38969b9 to fa20b1b Compare March 4, 2020 12:56

kotreshhr force-pushed the libcephfs-pybind-1 branch 2 times, most recently from fb056d4 to 7d7ab98 Compare March 5, 2020 21:01

kotreshhr force-pushed the libcephfs-pybind-1 branch 3 times, most recently from 075289b to ec37282 Compare March 11, 2020 04:38

kotreshhr force-pushed the libcephfs-pybind-1 branch from ec37282 to 1956e61 Compare March 13, 2020 05:45

gregsfortytwo requested a review from rishabh-d-dave March 26, 2020 04:29

gregsfortytwo assigned rishabh-d-dave Mar 26, 2020

vshankar requested a review from a team April 3, 2020 07:43

kotreshhr added 6 commits April 14, 2020 16:09

libcephfs/pybind: Add fallocate, mknod

eb528b6

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add lazyio, lazyio_propagate, lazyio_synchronize

85b5a6b

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add get_file_replication, get_path_replication

0fcea92

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add get_pool_id, get_pool_replication

e8b9271

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add debug_get_fd_caps, debug_get_file_caps, get_cap…

4fee2e7

…_return_timeout Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add set_uuid, set_session_timeout

25f0e2d

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

kotreshhr force-pushed the libcephfs-pybind-1 branch 3 times, most recently from 6388220 to a123c6f Compare April 14, 2020 11:40

rishabh-d-dave reviewed Apr 27, 2020

View reviewed changes

rishabh-d-dave reviewed May 5, 2020

View reviewed changes

src/test/pybind/test_cephfs.py Outdated Show resolved Hide resolved

src/test/pybind/test_cephfs.py Show resolved Hide resolved

src/test/pybind/test_cephfs.py Show resolved Hide resolved

src/test/pybind/test_cephfs.py Outdated Show resolved Hide resolved

rishabh-d-dave self-requested a review May 5, 2020 13:27

kotreshhr added 5 commits May 21, 2020 17:01

libcephfs/pybind: Add rewinddir, telldir, seekdir

626febc

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add pwritev, preadv

2c5fc05

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add setattrx, fsetattrx

a5b140b

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add get_layout, get_default_pool

7aed26b

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

libcephfs/pybind: Add truncate, ftruncate

ee14806

Fixes: https://tracker.ceph.com/issues/44171 Signed-off-by: Kotresh HR <khiremat@redhat.com>

kotreshhr force-pushed the libcephfs-pybind-1 branch from a123c6f to ee14806 Compare May 21, 2020 11:39

rishabh-d-dave approved these changes May 25, 2020

View reviewed changes

batrick added needs-qa wip-pdonnell-testing and removed needs-review labels Jun 8, 2020

batrick approved these changes Jun 8, 2020

View reviewed changes

batrick merged commit 9c09027 into ceph:master Jun 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libcephfs/pybind: Add missing python bindings #33406

libcephfs/pybind: Add missing python bindings #33406

kotreshhr commented Feb 19, 2020 •

edited by rishabh-d-dave

varshar16 commented Feb 25, 2020 •

edited

kotreshhr commented Mar 4, 2020

kotreshhr commented Mar 5, 2020

kotreshhr commented Mar 11, 2020

kotreshhr commented Mar 19, 2020

kotreshhr commented Apr 20, 2020

rishabh-d-dave left a comment

rishabh-d-dave left a comment

rishabh-d-dave commented May 5, 2020

ukernel commented May 6, 2020

kotreshhr commented May 21, 2020

rishabh-d-dave May 25, 2020

kotreshhr May 26, 2020

batrick May 26, 2020

rishabh-d-dave May 27, 2020

batrick commented Jun 12, 2020

batrick commented Jun 12, 2020

libcephfs/pybind: Add missing python bindings #33406

libcephfs/pybind: Add missing python bindings #33406

Conversation

kotreshhr commented Feb 19, 2020 • edited by rishabh-d-dave

Checklist

varshar16 commented Feb 25, 2020 • edited

kotreshhr commented Mar 4, 2020

kotreshhr commented Mar 5, 2020

kotreshhr commented Mar 11, 2020

kotreshhr commented Mar 19, 2020

kotreshhr commented Apr 20, 2020

rishabh-d-dave left a comment

Choose a reason for hiding this comment

rishabh-d-dave left a comment

Choose a reason for hiding this comment

rishabh-d-dave commented May 5, 2020

ukernel commented May 6, 2020

kotreshhr commented May 21, 2020

rishabh-d-dave May 25, 2020

Choose a reason for hiding this comment

kotreshhr May 26, 2020

Choose a reason for hiding this comment

batrick May 26, 2020

Choose a reason for hiding this comment

rishabh-d-dave May 27, 2020

Choose a reason for hiding this comment

batrick commented Jun 12, 2020

batrick commented Jun 12, 2020

kotreshhr commented Feb 19, 2020 •

edited by rishabh-d-dave

varshar16 commented Feb 25, 2020 •

edited