octopus: mon: calculate min_size on osd pool set size #34528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-ojha
requested changes
Apr 15, 2020
There was a problem hiding this comment.
@smithfarm we don't want to backport #33281, see https://tracker.ceph.com/issues/44025#note-8. Is there a reason why you think we should?
|
@neha-ojha My understanding was that it should not be backported to nautilus. But if it's a pacific-only feature, then we shouldn't backport it to octopus, either, and I'll remove it from this PR.
|
added 2 commits
April 16, 2020 10:30
currently `osd pool set size` only modifies min_size when it is above new size, while it should be recalculated unconditionally. fixes: https://tracker.ceph.com/issues/44862 Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com> (cherry picked from commit b69dcaa)
verify whether min_size is recalculated when osd pool size is changed. fixes: https://tracker.ceph.com/issues/44862 Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com> (cherry picked from commit 0a7325a) Conflicts: qa/workunits/mon/pool_ops.sh - master/pacific needs "--yes-i-really-mean-it" when setting pool size to 1
smithfarm
force-pushed
the
wip-45039-octopus
branch
from
8a35a23
to
d2ae92c
Compare
|
@neha-ojha Please have another look - I removed the feature cherry-pick. |
neha-ojha
approved these changes
Apr 17, 2020
@smithfarm looks good, thanks! |
ideepika
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker:
backport of
parent tracker:
this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh