nautilus: common/ceph_time: tolerate mono time going backwards #34542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdurgin
approved these changes
Apr 13, 2020
Some kernels (and possibly some hardware?) can trigger a monotonic clock that goes back in time. That, in turn, can lead to a negative monotonic time span. This would trigger an assert. This this problem seems to be widespread, tolerate the case and interpret it as a 0-length interval (vs something negative). Fixes: https://tracker.ceph.com/issues/44078 Fixes: https://tracker.ceph.com/issues/43365 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit cd00378)
smithfarm
force-pushed
the
wip-44486-nautilus
branch
from
0fcc74e
to
8026f1f
Compare
|
Unrelated "make check" failure: |
tchaikov
approved these changes
Apr 16, 2020
|
test this please |
|
@smithfarm I am hesitant to merge with failed tests in this PR, although seem unrelated, pls merge t will, it was tested |
|
This time it was |
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/44486
backport of #33699
parent tracker: https://tracker.ceph.com/issues/43365
this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh