Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Forms now wait for all data to load until displayed #34746

Merged
merged 1 commit into from May 12, 2020
Merged

mgr/dashboard: Forms now wait for all data to load until displayed #34746

merged 1 commit into from May 12, 2020

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Apr 24, 2020 •
edited by votdev

Add directive to handle the display of the form.
It will display the form only when loading is finished.
Otherwise it will show a loading message or error message.

Add a new class that should be extended by all form components.
For now it only has methods for dealing with loading,
but this could be improved later.

Fixes: https://tracker.ceph.com/issues/44912

Signed-off-by: Tiago Melo tmelo@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard backend
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@tspmelo tspmelo requested a review from a team as a code owner April 24, 2020 17:34
@tspmelo
Copy link
Contributor Author

tspmelo commented Apr 24, 2020

jenkins test docs

1 similar comment
@tchaikov
Copy link
Contributor

jenkins test docs

@votdev votdev requested a review from a team April 28, 2020 09:12
@votdev votdev added the feature label Apr 28, 2020
@tspmelo
Copy link
Contributor Author

tspmelo commented Apr 28, 2020

jenkins test make check

Devp00l
Devp00l reviewed Apr 29, 2020
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments so far, one (new) left for my approve ;)

Devp00l
Devp00l approved these changes Apr 29, 2020
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all my comments :D

@tspmelo tspmelo requested a review from a team April 29, 2020 15:43
@tspmelo tspmelo added the DNM label Apr 29, 2020
@tspmelo tspmelo removed the DNM label Apr 29, 2020
mgr/dashboard: Forms now wait for all data to load until displayed
8afe262 
Add directive to handle the display of the form.
It will display the form only when loading is finished.
Otherwise it will show a loading message or error message.

Add a new class that should be extended by all form components.
For now it only has methods for dealing with loading,
but this could be improved later.

Fixes: https://tracker.ceph.com/issues/44912

Signed-off-by: Tiago Melo <tmelo@suse.com>
@alfonsomthd alfonsomthd requested a review from epuertat May 12, 2020 13:07
@LenzGr LenzGr merged commit 6fd685d into ceph:master May 12, 2020
@tspmelo tspmelo deleted the wip-form-loading branch May 12, 2020 13:39
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jun 26, 2020
mgr/dashboard: add telemetry activation notification
bd359cd 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jun 26, 2020
mgr/dashboard: add telemetry activation notification
7ab616a 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jun 26, 2020
mgr/dashboard: add telemetry activation notification
3709f7f 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934
s0nea pushed a commit to s0nea/ceph that referenced this pull request Jul 29, 2020
mgr/dashboard: add telemetry activation notification
4952bf6 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

The backport contains one commit less (39a26ae
is missing) than the original pull request because the migration from alert to
ngb-alert (ceph#35297) has not been backported.
s0nea pushed a commit to s0nea/ceph that referenced this pull request Aug 11, 2020
mgr/dashboard: add telemetry activation notification
f823d72 
The commit adds 2 different parts to show the
Telemetry activation notification in the dashboard:

1. The Telemetry activation notification component
   itself. It contains the definition of the
   notification panel.
2. The Telemetry notification service. The service
   is needed to be able to show/hide the
   notification from:
   * the component itself (e.g. when clicking the
     button button)
   * the Telemetry configuration component (when
     enabling/disabling Telemetry)
   * the navigation component (to set the css-
     classes accordingly)

Fixes: https://tracker.ceph.com/issues/45464
Signed-off-by: Tatjana Dehler <tdehler@suse.com>
(cherry picked from commit f7e4579)

Conflicts:
	src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/telemetry/telemetry.component.ts
	A form loading directive has been introduced in master: ceph#34746

	src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts
	The test configuration has been improved in master: ceph#34965

	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.html
	src/pybind/mgr/dashboard/frontend/src/app/shared/components/telemetry-notification/telemetry-notification.component.spec.ts
	The alert component has been migrated from ngx-bootstrap to ng-boostrap in master: ceph#35297
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

	src/pybind/mgr/dashboard/frontend/src/app/shared/services/telemetry-notification.service.spec.ts
	TestBed.get has been replaced by TestBed.inject in master: ceph#34934

The backport contains one commit less (39a26ae
is missing) than the original pull request because the migration from alert to
ngb-alert (ceph#35297) has not been backported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfonsomthd alfonsomthd alfonsomthd approved these changes

@Devp00l Devp00l Devp00l approved these changes

@epuertat epuertat Awaiting requested review from epuertat

Assignees
No one assigned
Labels
dashboard feature
Projects
None yet
Milestone
No milestone
6 participants
@tspmelo @tchaikov @alfonsomthd @Devp00l @LenzGr @votdev