nautilus: mon/OSDMonitor: allow trimming maps even if osds are down #34983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joao Eduardo Luis <joao@suse.de> (cherry picked from commit bd2e5c6)
Signed-off-by: Joao Eduardo Luis <joao@suse.de> (cherry picked from commit 3d682c2)
If we also consider down osds, we may very well be in a healthy state but keeping maps as far back as the last epoch when a given osd went down. If said osd stays down for eons, we will be keeping bajillions of maps that we shouldn't. Signed-off-by: Joao Eduardo Luis <joao@suse.de> (cherry picked from commit e62269c)
neha-ojha
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/45402
backport of #19076
parent tracker: https://tracker.ceph.com/issues/45400
this backport was staged using ceph-backport.sh version 15.1.1.389
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh