rgw: fix shutdown crash in RGWAsyncReadMDLogEntries #35316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RGWAsyncReadMDLogEntries must not store pointers into coroutine memory, because it's not guaranteed to outlive our call. store these by-value instead, and have RGWReadMDLogEntriesCR::request_complete() copy/move them back on completion Fixes: https://tracker.ceph.com/issues/45771 Signed-off-by: Casey Bodley <cbodley@redhat.com>
smanjara
approved these changes
Jun 1, 2020
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
Teuthology results: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RGWAsyncReadMDLogEntries must not store pointers into coroutine memory, because it's not guaranteed to outlive our call. store these by-value instead, and have RGWReadMDLogEntriesCR::request_complete() copy/move them back on completion
Fixes: https://tracker.ceph.com/issues/45771
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard backendjenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox