ceph-volume: add dmcrypt support in raw mode #35468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please attach the tracker bug for the backport: https://tracker.ceph.com/issues/45959 |
guits
commented
Jun 16, 2020
guits
force-pushed
the
guits-raw_dmcrypt
branch
3 times, most recently
from
3857883
to
42527b5
Compare
jan--f
suggested changes
Jun 19, 2020
guits
force-pushed
the
guits-raw_dmcrypt
branch
4 times, most recently
from
394923a
to
32be2af
Compare
guits
force-pushed
the
guits-raw_dmcrypt
branch
3 times, most recently
from
08b3784
to
532a90a
Compare
guits
commented
Jun 23, 2020
guits
force-pushed
the
guits-raw_dmcrypt
branch
6 times, most recently
from
0b98e54
to
ca2475b
Compare
jan--f
approved these changes
Jun 25, 2020
|
jenkins test ceph-volume tox |
|
jenkins test ceph-volume tox |
This commit adds the dmcrypt support in `ceph-volume raw` mode. Note about `ceph-volume raw list` change: Given `lsblk -J` (json output) option isn't available on all OS, I came up with adding '--inverse' option to the existing command which allows us to get the mapper devices list in that command output. Not listing root devices containing partitions shouldn't have side effect since we are in `ceph-volume raw` context. example: running `lsblk --paths --nodeps --output=NAME --noheadings` doesn't allow to get the mapper list because the output is like following : $ lsblk --paths --nodeps --output=NAME --noheadings /dev/sda /dev/sdb /dev/sdc /dev/sdd the dmcrypt mappers are hidden because of the `--nodeps` given they are displayed as a dependency. $ lsblk --paths --output=NAME --noheadings /dev/sda |-/dev/mapper/ceph-3b52c90d-6548-407d-bde1-efd31809702f-sda-block-dmcrypt `-/dev/mapper/ceph-3b52c90d-6548-407d-bde1-efd31809702f-sda-db-dmcrypt /dev/sdb /dev/sdc /dev/sdd adding `--inverse` is a trick to get around this issue, the counterpart is that we can't list root devices if they contain at least one partition but this shouldn't be an issue in `ceph-volume raw` context given we only deal with raw devices. Fixes: https://tracker.ceph.com/issues/45959 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This commit adds testing against `ceph-volume raw` subcommand. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This function is never called in raw context, let's remove it. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
|
jenkins test ceph-volume tox |
This was referenced Jun 29, 2020
|
Why we don't need to decrypt the device during the activate process? I see that during the activate process of the lvm mode, it will call LUKS open to decrypt the device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the dmcrypt support in
ceph-volume rawmode.Fixes: https://tracker.ceph.com/issues/45959
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com