Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/DaemonServer.cc: make 'config show' on fsid work #35662

Merged
merged 1 commit into from Jun 24, 2020
Merged

mgr/DaemonServer.cc: make 'config show' on fsid work #35662

merged 1 commit into from Jun 24, 2020

Conversation

neha-ojha
Copy link
Member

@neha-ojha neha-ojha commented Jun 18, 2020 •
edited by smithfarm

This follows 5661dd7, which added special
handling for "config get" to work on fsid.

Fixes: https://tracker.ceph.com/issues/46123
Signed-off-by: Neha Ojha nojha@redhat.com

@neha-ojha
Copy link
Member Author 

nojha@vossi06:~/work/ceph/build$ ./bin/ceph config show osd.0 fsid
7b4ea7a3-6cd7-4c37-a395-7017967a7f12

@neha-ojha neha-ojha requested a review from jdurgin June 18, 2020 22:13
@tchaikov
Copy link
Contributor

jenkins test docs

2 similar comments
@tchaikov
Copy link
Contributor

jenkins test docs

@tchaikov
Copy link
Contributor

jenkins test docs

smithfarm
smithfarm previously requested changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@smithfarm smithfarm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the old tracker https://tracker.ceph.com/issues/42820 was used to backport #32726, we cannot re-use it here (at least, not without making both backports, original and new, difficult to track).

I created a new issue https://tracker.ceph.com/issues/46123 for this PR. Could you please change the Fixes line to point to the new issue?

Also, if the description of https://tracker.ceph.com/issues/42820 does not match the bug that was fixed by #32726 it would be great if could replace the incorrect description with a correct/meaningful one.

@neha-ojha
mgr/DaemonServer.cc: make 'config show' on fsid work
3ca2c48 
This follows 5661dd7, which added special
handling for "config get" to work on fsid.

Fixes: https://tracker.ceph.com/issues/46123
Signed-off-by: Neha Ojha <nojha@redhat.com>
@neha-ojha
Copy link
Member Author

Since the old tracker https://tracker.ceph.com/issues/42820 was used to backport #32726, we cannot re-use it here (at least, not without making both backports, original and new, difficult to track).

I created a new issue https://tracker.ceph.com/issues/46123 for this PR. Could you please change the Fixes line to point to the new issue?

done

Also, if the description of https://tracker.ceph.com/issues/42820 does not match the bug that was fixed by #32726 it would be great if could replace the incorrect description with a correct/meaningful one.

done

@neha-ojha neha-ojha requested a review from smithfarm June 22, 2020 17:44
@smithfarm smithfarm dismissed their stale review June 22, 2020 19:57

Looks good now, thanks!

@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit 850e7d0 into ceph:master Jun 24, 2020
@callithea callithea mentioned this pull request Jun 26, 2020
Merged
@neha-ojha neha-ojha mentioned this pull request Jul 13, 2020
Merged
@neha-ojha neha-ojha deleted the wip-42820 branch July 14, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

@smithfarm smithfarm Awaiting requested review from smithfarm

Assignees
No one assigned
Labels
bug-fix mgr needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
4 participants
@neha-ojha @tchaikov @jdurgin @smithfarm