nautilus: ceph-volume: don't use container classes in api/lvm.py #35878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test ceph-volume tox |
|
jenkins test dashboard backend |
|
I've backported #36219 here as well. |
|
jenkins test ceph-volume tox |
|
jenkins test dashboard backend |
|
jenkins test dashboard backend |
andrewschoen
force-pushed
the
wip-nautilus-32493
branch
from
40d3234
to
1d4229a
Compare
|
jenkins test ceph-volume tox |
|
Something is off with the API tests. Maybe someone from the @ceph/dashboard team can chime in here? |
|
jenkins test make check |
|
jenkins test ceph-volume tox |
|
jenkins test dashboard backend |
Replace code using class Volumes by methods get_lvs() and get_first_lv(). Also, update the tests accordingly. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 2f5c10c)
Use api.lvm.get_lvs() and api.lvm.get_first_lv() instead and update tests. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 5301c49)
Use api.lvm.get_lvs() and api.lvm.get_first_lv() instead and update the tests. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit b225405)
Update api.lvm.get_first_pv() and api.lvm.get_pvs() instead and update tests. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit a6e3c69)
Use api.lvm.get_vgs() and api.lvm.get_first_vg() instead and update tests. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit dfe6b1b)
Since it calls get_lv_from_argument() internally and use get_first_lv() instead and update tests. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit ca1d3e6)
2f5c10c introduced a bug: `ceph-volume lvm zap` command fails under certain conditions. when passing `--osd-id` or `--osd-fsid` to `ceph-volume lvm zap` command it tries to zap additionnal devices that have nothing to do with the osd being zapped. When calling `api.get_lvs()` in `ensure_associated_lvs()` we have to pass the osd-id/osd-fsid information so only related devices are returned by `get_lvs()` method Closes: https://tracker.ceph.com/issues/46627 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit e94aef6)
andrewschoen
force-pushed
the
wip-nautilus-32493
branch
from
1d4229a
to
7ecf8c9
Compare
|
jenkins test ceph-volume tox |
|
Wrote a fix - #36493. #36372 contains a fix but there's no plan to backport it beyond Octopus (see - #36372 (comment)). |
jan--f
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32493 and #36219